<div dir="ltr">Ping.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 18, 2016 at 5:08 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Thu, Feb 18, 2016 at 9:35 AM, Ed Maste via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: emaste<br>
Date: Thu Feb 18 11:35:30 2016<br>
New Revision: 261229<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=261229&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=261229&view=rev</a><br>
Log:<br>
[tsan] Disable sysroot flag on FreeBSD<br>
<br>
FreeBSD does not install a number of Clang-provided headers for the<br>
compiler in the base system due to incompatibilities between FreeBSD's<br>
and Clang's versions. As a workaround do not use --sysroot=. on FreeBSD<br>
until this is addressed.<br></blockquote><div><br></div></span><div>Out of curiousity, how do you currently make sure that you only install a subset of clang's builtin headers? Is it with an out-of-tree mechanism? We do it out of tree for PS4 and I'm curious how you guys are doing it.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- Sean Silva </div></font></span><div><div class="h5"><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<a href="http://llvm.org/pr26651" rel="noreferrer" target="_blank">llvm.org/pr26651</a><br>
Differential Revision:  <a href="http://reviews.llvm.org/D17383" rel="noreferrer" target="_blank">http://reviews.llvm.org/D17383</a><br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/tsan/CMakeLists.txt<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/CMakeLists.txt?rev=261229&r1=261228&r2=261229&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/CMakeLists.txt?rev=261229&r1=261228&r2=261229&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/lib/tsan/CMakeLists.txt Thu Feb 18 11:35:30 2016<br>
@@ -192,7 +192,11 @@ endif()<br>
 add_dependencies(compiler-rt tsan)<br>
<br>
 # Make sure that non-platform-specific files don't include any system headers.<br>
-if(COMPILER_RT_HAS_SYSROOT_FLAG)<br>
+# FreeBSD does not install a number of Clang-provided headers for the compiler<br>
+# in the base system due to incompatibilities between FreeBSD's and Clang's<br>
+# versions. As a workaround do not use --sysroot=. on FreeBSD until this is<br>
+# addressed.<br>
+if(COMPILER_RT_HAS_SYSROOT_FLAG AND NOT CMAKE_SYSTEM_NAME MATCHES "FreeBSD")<br>
   file(GLOB _tsan_generic_sources rtl/tsan*)<br>
   file(GLOB _tsan_platform_sources rtl/tsan*posix* rtl/tsan*mac*<br>
                                    rtl/tsan*linux*)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>