<div dir="ltr">Maggie, Phillip,<div><br></div><div>This should Just Work after undoing any internal #ifdef's forcing the InstrProfilingPlatformOther.c code path, but let me know if you guys run into any issues.</div><div><br></div><div>-- Sean Silva<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 26, 2016 at 10:01 PM, Sean Silva via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: silvas<br>
Date: Sat Feb 27 00:01:26 2016<br>
New Revision: 262112<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=262112&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=262112&view=rev</a><br>
Log:<br>
[instrprof] Use __{start,stop}_SECNAME on PS4 too.<br>
<br>
Summary:<br>
The PS4 linker seems to handle this fine.<br>
<br>
Hi David, it seems that indeed most ELF linkers support<br>
__{start,stop}_SECNAME, as our proprietary linker does as well.<br>
<br>
This follows the pattern of r250679 w.r.t. the testing.<br>
<br>
Maggie, Phillip, Paul: I've tested this with the PS4 SDK 3.5 toolchain<br>
prerelease and it seems to work fine.<br>
<br>
Reviewers: davidxl<br>
<br>
Subscribers: probinson, phillip.power, MaggieYi<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D17672" rel="noreferrer" target="_blank">http://reviews.llvm.org/D17672</a><br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp<br>
    llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll<br>
<br>
Modified: llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp?rev=262112&r1=262111&r2=262112&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp?rev=262112&r1=262111&r2=262112&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp Sat Feb 27 00:01:26 2016<br>
@@ -406,7 +406,8 @@ void InstrProfiling::emitRegistration()<br>
<br>
   // Use linker script magic to get data/cnts/name start/end.<br>
   if (Triple(M->getTargetTriple()).isOSLinux() ||<br>
-      Triple(M->getTargetTriple()).isOSFreeBSD())<br>
+      Triple(M->getTargetTriple()).isOSFreeBSD() ||<br>
+      Triple(M->getTargetTriple()).isPS4CPU())<br>
     return;<br>
<br>
   // Construct the function.<br>
<br>
Modified: llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll?rev=262112&r1=262111&r2=262112&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll?rev=262112&r1=262111&r2=262112&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll (original)<br>
+++ llvm/trunk/test/Instrumentation/InstrProfiling/platform.ll Sat Feb 27 00:01:26 2016<br>
@@ -3,6 +3,7 @@<br>
 ; RUN: opt < %s -mtriple=x86_64-apple-macosx10.10.0 -instrprof -S | FileCheck %s -check-prefix=MACHO<br>
 ; RUN: opt < %s -mtriple=x86_64-unknown-linux -instrprof -S | FileCheck %s -check-prefix=LINUX<br>
 ; RUN: opt < %s -mtriple=x86_64-unknown-freebsd -instrprof -S | FileCheck %s -check-prefix=FREEBSD<br>
+; RUN: opt < %s -mtriple=x86_64-scei-ps4 -instrprof -S | FileCheck %s -check-prefix=PS4<br>
 ; RUN: opt < %s -mtriple=x86_64-pc-solaris -instrprof -S | FileCheck %s -check-prefix=SOLARIS<br>
<br>
 @__profn_foo = hidden constant [3 x i8] c"foo"<br>
@@ -15,6 +16,7 @@<br>
 ; MACHO: @__profd_foo = hidden {{.*}}, section "__DATA,__llvm_prf_data", align 8<br>
 ; LINUX: @__profd_foo = hidden {{.*}}, section "__llvm_prf_data", align 8<br>
 ; FREEBSD: @__profd_foo = hidden {{.*}}, section "__llvm_prf_data", align 8<br>
+; PS4: @__profd_foo = hidden {{.*}}, section "__llvm_prf_data", align 8<br>
 ; SOLARIS: @__profd_foo = hidden {{.*}}, section "__llvm_prf_data", align 8<br>
<br>
 ; ELF: @__llvm_prf_nm = private constant [{{.*}} x i8] c"{{.*}}", section "{{.*}}__llvm_prf_names"<br>
@@ -32,9 +34,11 @@ declare void @llvm.instrprof.increment(i<br>
 ; MACHO-NOT: define internal void @__llvm_profile_register_functions<br>
 ; LINUX-NOT: define internal void @__llvm_profile_register_functions<br>
 ; FREEBSD-NOT: define internal void @__llvm_profile_register_functions<br>
+; PS4-NOT: define internal void @__llvm_profile_register_functions<br>
 ; SOLARIS: define internal void @__llvm_profile_register_functions<br>
<br>
 ; MACHO-NOT: define internal void @__llvm_profile_init<br>
 ; LINUX-NOT: define internal void @__llvm_profile_init<br>
 ; FREEBSD-NOT: define internal void @__llvm_profile_init<br>
+; PS4-NOT: define internal void @__llvm_profile_init<br>
 ; SOLARIS: define internal void @__llvm_profile_init<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></div>