<div dir="ltr"><div><div style="font-size:13px;line-height:19.5px"><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/421/steps/build/logs/warnings%20%281%29" target="_blank" class="cremed">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/421/steps/build/logs/warnings%20%281%29</a><br></div><pre style="font-family:'Courier New',courier,monotype,monospace;color:rgb(0,0,0);font-size:medium"><br></pre><pre style="font-family:'Courier New',courier,monotype,monospace;color:rgb(0,0,0);font-size:medium">C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\sancov\sancov.cc(724): warning C4709: comma operator within array index expression<br></pre></div><div><br></div><div><br></div><br><div class="gmail_quote"><div dir="ltr">On Sun, Feb 21, 2016 at 3:38 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank" class="cremed">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Feb 19, 2016 at 6:11 PM, Mike Aizatsky via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="cremed">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aizatsky<br>
Date: Fri Feb 19 20:11:49 2016<br>
New Revision: 261396<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=261396&view=rev" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=261396&view=rev</a><br>
Log:<br>
fixing msvc warning.<br></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>What was the MSVC warning?</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/tools/sancov/sancov.cc<br>
<br>
Modified: llvm/trunk/tools/sancov/sancov.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/sancov/sancov.cc?rev=261396&r1=261395&r2=261396&view=diff" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/sancov/sancov.cc?rev=261396&r1=261395&r2=261396&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/sancov/sancov.cc (original)<br>
+++ llvm/trunk/tools/sancov/sancov.cc Fri Feb 19 20:11:49 2016<br>
@@ -721,7 +721,8 @@ public:<br>
       if (!ProcessedFunctions.insert(FunctionName).second)<br>
         continue;<br>
<br>
-      Result[FileLoc{FileName, Loc.Loc.Line}].insert(FunctionName);<br>
+      auto FLoc = FileLoc{FileName, Loc.Loc.Line};<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br>Could we just write this as:<br><br>FileLoc FLoc = {FileName, Loc.Loc.Line};<br><br>Or<br><br>FileLoc FLoc(FileName, Loc.Loc.Line);<br><br>(prefer the latter if we're actually calling a ctor, the former if it's really an aggregate with no user-declared ctor)<br> </div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+      Result[FLoc].insert(FunctionName);<br>
     }<br>
     return Result;<br>
   }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="cremed">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="cremed">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div></blockquote></div></div>