<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 22, 2016 at 4:48 PM, Michael Zolotukhin via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mzolotukhin<br>
Date: Mon Feb 22 18:48:44 2016<br>
New Revision: 261597<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=261597&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=261597&view=rev</a><br>
Log:<br>
Follow-up for r261595: use range loop.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp?rev=261597&r1=261596&r2=261597&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp?rev=261597&r1=261596&r2=261597&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp Mon Feb 22 18:48:44 2016<br>
@@ -112,10 +112,8 @@ FoldBlockIntoPredecessor(BasicBlock *BB,<br>
     if (DomTreeNode *DTN = DT->getNode(BB)) {<br>
       DomTreeNode *PredDTN = DT->getNode(OnlyPred);<br>
       SmallVector<DomTreeNode *, 8> Children(DTN->begin(), DTN->end());<br>
-      for (SmallVectorImpl<DomTreeNode *>::iterator DI = Children.begin(),<br>
-                                                    DE = Children.end();<br>
-           DI != DE; ++DI)<br>
-        DT->changeImmediateDominator(*DI, PredDTN);<br>
+      for (auto DI : Children)<br></blockquote><div><br></div><div>Please add the * to the auto, just to make the cheapness of the value clear:<br><br>  for (auto *DI : Children)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+        DT->changeImmediateDominator(DI, PredDTN);<br>
<br>
       DT->eraseNode(BB);<br>
     }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>