<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Unfortunately IIRC it involved 800 files, and I don't have them. I need to reproduce and it'll take some time. I can send you the IR *after* importing (the broken module) if it can help (not sure).<div class=""><br class=""></div><div class="">-- </div><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div class=""><div><blockquote type="cite" class=""><div class="">On Feb 22, 2016, at 5:52 PM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="">tejohnson@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Can you give me a test case to reproduce, or at least the IR for the module we're importing from (where these presumably came from) and which function(s) were imported?<div class=""><br class=""></div><div class="">Thanks,</div><div class="">Teresa</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Feb 22, 2016 at 5:37 PM, Mehdi Amini <span dir="ltr" class=""><<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We still have an issue with this patch, when compiling this with thinlto and debug info: <a href="https://github.com/adobe/webkit/blob/master/Source/WebCore/inspector/InspectorRuntimeAgent.cpp" rel="noreferrer" target="_blank" class="">https://github.com/adobe/webkit/blob/master/Source/WebCore/inspector/InspectorRuntimeAgent.cpp</a><br class="">
<br class="">
I haven't had time to narrow it unfortunately, it seems that "baseType" for some DIDerivedType entries are not present.<br class="">
What we see is a broken LLVM Module straight after the FunctionImporter. The output looks like this:<br class="">
<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC14ScopeLabelInfoE"<br class="">
!121713 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !"_ZTSN3JSC14ScopeLabelInfoE", size: 64, align: 64)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC15DeclarationTypeE"<br class="">
!121577 = !DISubroutineType(types: !121578)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC17AssignmentContextE"<br class="">
!121580 = !DISubroutineType(types: !121581)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC17DestructuringKindE"<br class="">
!121577 = !DISubroutineType(types: !121578)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC21DeclarationImportTypeE"<br class="">
!121606 = !DISubroutineType(types: !121607)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC23SourceProviderCacheItemE"<br class="">
!121621 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !"_ZTSN3JSC23SourceProviderCacheItemE")<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerIhEEE10LexerStateE"<br class="">
!121743 = !DISubroutineType(types: !121744)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerIhEEE15AutoPopScopeRefE"<br class="">
!121600 = !DIDerivedType(tag: DW_TAG_reference_type, baseType: !"_ZTSN3JSC6ParserINS_5LexerIhEEE15AutoPopScopeRefE", size: 64, align: 64)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerIhEEE20ExpressionErrorClassE"<br class="">
!121571 = !DISubroutineType(types: !121572)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerIhEEE23AutoCleanupLexicalScopeE"<br class="">
!121604 = !DIDerivedType(tag: DW_TAG_reference_type, baseType: !"_ZTSN3JSC6ParserINS_5LexerIhEEE23AutoCleanupLexicalScopeE", size: 64, align: 64)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerIhEEE25ExpressionErrorClassifierE"<br class="">
!121535 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !"_ZTSN3JSC6ParserINS_5LexerIhEEE25ExpressionErrorClassifierE", size: 64, align: 64)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerIhEEE9SavePointE"<br class="">
!121751 = !DISubroutineType(types: !121752)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerItEEE10LexerStateE"<br class="">
!122000 = !DISubroutineType(types: !122001)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerItEEE15AutoPopScopeRefE"<br class="">
!121866 = !DIDerivedType(tag: DW_TAG_reference_type, baseType: !"_ZTSN3JSC6ParserINS_5LexerItEEE15AutoPopScopeRefE", size: 64, align: 64)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerItEEE20ExpressionErrorClassE"<br class="">
!121838 = !DISubroutineType(types: !121839)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerItEEE23AutoCleanupLexicalScopeE"<br class="">
!121870 = !DIDerivedType(tag: DW_TAG_reference_type, baseType: !"_ZTSN3JSC6ParserINS_5LexerItEEE23AutoCleanupLexicalScopeE", size: 64, align: 64)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerItEEE25ExpressionErrorClassifierE"<br class="">
!121803 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !"_ZTSN3JSC6ParserINS_5LexerItEEE25ExpressionErrorClassifierE", size: 64, align: 64)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC6ParserINS_5LexerItEEE9SavePointE"<br class="">
!122008 = !DISubroutineType(types: !122009)<br class="">
unresolved type ref<br class="">
!"_ZTSN3JSC9ScopeNodeE"<br class="">
!121635 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !"_ZTSN3JSC9ScopeNodeE", size: 64, align: 64)<br class="">
<br class="">
<br class="">
--<br class="">
Mehdi<br class="">
<div class=""><div class="h5"><br class="">
<br class="">
> On Feb 22, 2016, at 2:20 PM, Teresa Johnson <<a href="mailto:tejohnson@google.com" class="">tejohnson@google.com</a>> wrote:<br class="">
><br class="">
> tejohnson updated this revision to Diff 48732.<br class="">
> tejohnson added a comment.<br class="">
><br class="">
> Handle a null MD passed to MapMetadata to address problem reported by<br class="">
> ahatanak.<br class="">
><br class="">
><br class="">
> <a href="http://reviews.llvm.org/D16440" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D16440</a><br class="">
><br class="">
> Files:<br class="">
> include/llvm/Linker/IRMover.h<br class="">
> lib/Linker/IRMover.cpp<br class="">
> lib/Linker/LinkModules.cpp<br class="">
> lib/Transforms/Utils/ValueMapper.cpp<br class="">
> test/Linker/thinlto_funcimport_debug.ll<br class="">
> test/Transforms/FunctionImport/Inputs/funcimport_debug.ll<br class="">
> test/Transforms/FunctionImport/funcimport_debug.ll<br class="">
><br class="">
</div></div>> <D16440.48732.patch><br class="">
<br class="">
</blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature"><span style="font-family: Times; font-size: inherit;" class=""><table cellspacing="0" cellpadding="0" class=""><tbody class=""><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small" class=""><td nowrap="" style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px" class="">Teresa Johnson |</td><td nowrap="" style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px" class=""> Software Engineer |</td><td nowrap="" style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px" class=""> <a href="mailto:tejohnson@google.com" target="_blank" class="">tejohnson@google.com</a> |</td><td nowrap="" style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px" class=""> 408-460-2413</td></tr></tbody></table></span></div>
</div>
</div></blockquote></div><br class=""></div></div></body></html>