<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 18, 2016 at 5:29 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@gmail.com" target="_blank">benny.kra@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Binding | tighter is the intended behavior in the DWARF spec, the<br>
warning is fixed in r261207.<br>
<br>
That being said, this commit should've come with a test case ...<br></blockquote><div><br></div><div>Agreed - was wondering if someone was going to call me on that... ;) Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
On Thu, Feb 18, 2016 at 3:39 AM, David Jones via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> This change appears to trigger -Werror=parentheses. I've attached two<br>
> patches: one with the semantically equivalent change (binding the +<br>
> more tightly than |), and another with what I believe is (probably?)<br>
> the intended behavior (binding | tighter than +, which matches the<br>
> original behavior of +=). Both pass check-llvm.<br>
><br>
><br>
><br>
> On Tue, Feb 16, 2016 at 11:00 PM, David Blaikie via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
>> Author: dblaikie<br>
>> Date: Wed Feb 17 01:00:22 2016<br>
>> New Revision: 261071<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=261071&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=261071&view=rev</a><br>
>> Log:<br>
>> Fix the hash function.<br>
>><br>
>> Modified:<br>
>>     llvm/trunk/tools/llvm-dwp/llvm-dwp.cpp<br>
>><br>
>> Modified: llvm/trunk/tools/llvm-dwp/llvm-dwp.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-dwp/llvm-dwp.cpp?rev=261071&r1=261070&r2=261071&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-dwp/llvm-dwp.cpp?rev=261071&r1=261070&r2=261071&view=diff</a><br>
>> ==============================================================================<br>
>> --- llvm/trunk/tools/llvm-dwp/llvm-dwp.cpp (original)<br>
>> +++ llvm/trunk/tools/llvm-dwp/llvm-dwp.cpp Wed Feb 17 01:00:22 2016<br>
>> @@ -203,7 +203,7 @@ static void writeIndex(MCStreamer &Out,<br>
>>      while (Buckets[H]) {<br>
>>        assert(S != IndexEntries[Buckets[H] - 1].Signature &&<br>
>>               "Duplicate type unit");<br>
>> -      H += ((S >> 32) & Mask) | 1;<br>
>> +      H = (H + ((S >> 32) & Mask) | 1) % Buckets.size();<br>
>>      }<br>
>>      Buckets[H] = i + 1;<br>
>>    }<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
</div></div></blockquote></div><br></div></div>