<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 18, 2016, at 14:48, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="">chandlerc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Feb 18, 2016 at 2:07 PM Jordan Rose via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jrose<br class="">
Date: Thu Feb 18 16:03:23 2016<br class="">
New Revision: 261268<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=261268&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=261268&view=rev</a><br class="">
Log:<br class="">
[ADT] Be less clever when using a nonce type for disambiguation.<br class="">
<br class="">
Old compilers don't like constexpr, but we're only going to use this in one<br class="">
place anyway: this file. Everyone else should go through PointerLikeTypeTraits.<br class="">
<br class="">
Update to r261259.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/include/llvm/ADT/PointerEmbeddedInt.h<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/ADT/PointerEmbeddedInt.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/PointerEmbeddedInt.h?rev=261268&r1=261267&r2=261268&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/PointerEmbeddedInt.h?rev=261268&r1=261267&r2=261268&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/ADT/PointerEmbeddedInt.h (original)<br class="">
+++ llvm/trunk/include/llvm/ADT/PointerEmbeddedInt.h Thu Feb 18 16:03:23 2016<br class="">
@@ -45,7 +45,9 @@ class PointerEmbeddedInt {<br class="">
Mask = static_cast<uintptr_t>(-1) << Bits<br class="">
};<br class="">
<br class="">
- static constexpr const struct RawValueTag {} RawValue = RawValueTag();<br class="">
+ struct RawValueTag {<br class="">
+ explicit RawValueTag() = default;<br class="">
+ };<br class=""></blockquote><div class=""><br class=""></div><div class="">Why not just "struct RawValueTag {};"? Not sure what all the explicit stuff is buying you here...</div></div></div></div></blockquote><br class=""></div><div>I had that at first, but then thought about what happened last time: a particular collision of types that no one had thought to check. I wanted to make sure no one invoked the raw constructor with "PointerEmbeddedInt(rawValue, {})".</div><div><br class=""></div><div>Jordan</div><br class=""></body></html>