<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Can you update phrabricator with the new patch? Putting it on a new
thread with a reference to this one is likely to get it more
attention. We're buried way down another discussion at this point
and most folks have probably stopped following. <br>
<br>
Also, can you give a bit of information about how you're planning to
use this? Just curious what the context (within LLVM) is?<br>
<br>
Philip<br>
<br>
<div class="moz-cite-prefix">On 02/12/2016 05:50 PM, Argyrios
Kyrtzidis via llvm-commits wrote:<br>
</div>
<blockquote
cite="mid:A8BF32C0-C3AC-4352-AAB8-B3E2B914F4D2@apple.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Feb 12, 2016, at 2:29 PM, Philip Reames <<a
moz-do-not-send="true"
href="mailto:listmail@philipreames.com" class=""><a class="moz-txt-link-abbreviated" href="mailto:listmail@philipreames.com">listmail@philipreames.com</a></a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type" class="">
<div text="#000000" bgcolor="#FFFFFF" class=""> <br
class="">
<br class="">
<div class="moz-cite-prefix">On 02/12/2016 01:19 PM, Chris
Lattner wrote:<br class="">
</div>
<blockquote
cite="mid:E760DCF4-3FF0-458D-B1D6-11553C388C32@apple.com"
type="cite" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8" class="">
On Feb 12, 2016, at 1:08 PM, Chandler Carruth <<a
moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:chandlerc@gmail.com"><a class="moz-txt-link-abbreviated" href="mailto:chandlerc@gmail.com">chandlerc@gmail.com</a></a>>
wrote:<br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div style="word-wrap:break-word" class="">
<div class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div
style="word-wrap:break-word"
class="">
<div class="">
<div class="">I got
permission internally
and contributed the
header under the LLVM
license, I don’t think
that whether it
originated from swift
repo or not makes any
difference here.</div>
<div class="">If you could
elaborate more on your
concerns it would be
helpful.</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">How do we know
whether any other contributor
to Swift authored some of the
code in this file? Does Apple
get copyright assignment for
all Swift contributions? Only
if Apple has copyright
assignment for all
contributions to Swift or only
people from Apple have every
contributed to this part of
Swift is asking internally
enough.</div>
<div class=""><br class="">
</div>
<div class="">And since this is
an open source project, it
would seem polite (even if not
necessary) to also ask the
community rather than just
asking internally. We don't
all work at Apple. =/</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">The code is 100% copyrighted by Apple.
The full history in the swift repo is here:</div>
<div class=""><a moz-do-not-send="true"
href="https://github.com/apple/swift/commits/master/include/swift/Basic/OptionSet.h"
class="">https://github.com/apple/swift/commits/master/include/swift/Basic/OptionSet.h</a></div>
<div class=""><br class="">
</div>
<div class="">There are two trivial patches by
non-apple contributors. Both are both single line
patches that adjust comments (one is the first line
of the file, one is the copyright date):</div>
<div class=""><a moz-do-not-send="true"
href="https://github.com/apple/swift/commit/1339b5403bbaf6205abb2bfdf7fabadef1aacc70#diff-1e8f8df8addd9510deea20d4bea2eda2"
class="">https://github.com/apple/swift/commit/1339b5403bbaf6205abb2bfdf7fabadef1aacc70#diff-1e8f8df8addd9510deea20d4bea2eda2</a></div>
<div class=""><a moz-do-not-send="true"
href="https://github.com/apple/swift/commit/e3a4147ac94e55fcab1d14e949f572b53d9eb638#diff-1e8f8df8addd9510deea20d4bea2eda2"
class="">https://github.com/apple/swift/commit/e3a4147ac94e55fcab1d14e949f572b53d9eb638#diff-1e8f8df8addd9510deea20d4bea2eda2</a></div>
<div class=""><br class="">
</div>
<div class="">That said, both of those patches are
irrelevant to the discussion, because Argyrios
removed the swift header and replaced it with the
LLVM header when he checked it in.</div>
</div>
</blockquote>
Just to be clear, you're saying that Apple owns the
copyright on the entire file as posted for review and can
thus relicense under the LLVM license? If so, that would
resolve the licensing concern. In the future, let's make
sure that gets mentioned in the review/commit thread to
avoid confusion.<br class="">
<br class="">
With that, we're back to "let's post a patch and get it
reviewed" per the normal process. <br class="">
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>See updated patch. MSVC 2013 had some trouble with the code
and there are parts ifdef’ed out for MSVC 2013.</div>
<div>Aaron was kind enough to offer feedback on the MSVC issues.</div>
<div>Per Jordan, the static assert that gives trouble for MSVC
is just an enforced style check.</div>
<div><br class="">
</div>
<div>The specific MSVC issues were:</div>
<div><br class="">
</div>
<div>Compiler crash:</div>
<div><a moz-do-not-send="true"
href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9718"
class="">http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9718</a></div>
<div>Compiler error in unit test:<br class="">
<a moz-do-not-send="true"
href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9720"
class="">http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9720</a><br
class="">
Unit test failure:<br class="">
<a class="moz-txt-link-freetext" href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9721">http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9721</a><br
class="">
<br class="">
</div>
</div>
=<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div>
<div><br class="">
</div>
<blockquote type="cite" class="">
<div class="">
<div text="#000000" bgcolor="#FFFFFF" class=""> <br
class="">
<br class="">
<br class="">
<br class="">
<br class="">
<blockquote
cite="mid:E760DCF4-3FF0-458D-B1D6-11553C388C32@apple.com"
type="cite" class="">
<div class="">
<div class=""><br class="">
</div>
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div style="word-wrap:break-word" class="">
<div class="">
<div class="">+ Chris, for comment.</div>
</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">Also, just to be clear (since I
think my original email wasn't terribly): I
think something as simple as this code
review thread would have been fine if you
had waited for the code review, and made it
clear why it was OK to contribute (only
Apple folks have touched it, or whatever).</div>
<div class=""><br class="">
</div>
<div class="">I'm not suggesting we need to
have some big or complex discussion. =] We
have plenty of those on harder subjects.</div>
</div>
</div>
</div>
</blockquote>
</div>
<div class=""><br class="">
</div>
<div class="">I agree that the header should get the
normal patch review!</div>
<div class=""><br class="">
</div>
<div class="">-Chris</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>