<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <br>
    <br>
    <div class="moz-cite-prefix">On 02/12/2016 01:19 PM, Chris Lattner
      wrote:<br>
    </div>
    <blockquote
      cite="mid:E760DCF4-3FF0-458D-B1D6-11553C388C32@apple.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      On Feb 12, 2016, at 1:08 PM, Chandler Carruth <<a
        moz-do-not-send="true" href="mailto:chandlerc@gmail.com"
        class=""><a class="moz-txt-link-abbreviated" href="mailto:chandlerc@gmail.com">chandlerc@gmail.com</a></a>> wrote:<br class="">
      <div>
        <blockquote type="cite" class="">
          <div class="">
            <div dir="ltr" class="">
              <div class="gmail_quote">
                <blockquote class="gmail_quote" style="margin:0 0 0
                  .8ex;border-left:1px #ccc solid;padding-left:1ex">
                  <div style="word-wrap:break-word" class="">
                    <div class="">
                      <blockquote type="cite" class="">
                        <div class="">
                          <div dir="ltr" class="">
                            <div class="gmail_quote">
                              <blockquote class="gmail_quote"
                                style="margin:0 0 0 .8ex;border-left:1px
                                #ccc solid;padding-left:1ex">
                                <div style="word-wrap:break-word"
                                  class="">
                                  <div class="">
                                    <div class="">I got permission
                                      internally and contributed the
                                      header under the LLVM license, I
                                      don’t think that whether it
                                      originated from swift repo or not
                                      makes any difference here.</div>
                                    <div class="">If you could elaborate
                                      more on your concerns it would be
                                      helpful.</div>
                                  </div>
                                </div>
                              </blockquote>
                              <div class=""><br class="">
                              </div>
                              <div class="">How do we know whether any
                                other contributor to Swift authored some
                                of the code in this file? Does Apple get
                                copyright assignment for all Swift
                                contributions? Only if Apple has
                                copyright assignment for all
                                contributions to Swift or only people
                                from Apple have every contributed to
                                this part of Swift is asking internally
                                enough.</div>
                              <div class=""><br class="">
                              </div>
                              <div class="">And since this is an open
                                source project, it would seem polite
                                (even if not necessary) to also ask the
                                community rather than just asking
                                internally. We don't all work at Apple.
                                =/</div>
                            </div>
                          </div>
                        </div>
                      </blockquote>
                    </div>
                  </div>
                </blockquote>
              </div>
            </div>
          </div>
        </blockquote>
        <div><br class="">
        </div>
        <div>The code is 100% copyrighted by Apple.  The full history in
          the swift repo is here:</div>
        <div><a moz-do-not-send="true"
href="https://github.com/apple/swift/commits/master/include/swift/Basic/OptionSet.h"
            class="">https://github.com/apple/swift/commits/master/include/swift/Basic/OptionSet.h</a></div>
        <div><br class="">
        </div>
        <div>There are two trivial patches by non-apple contributors.
           Both are both single line patches that adjust comments (one
          is the first line of the file, one is the copyright date):</div>
        <div><a moz-do-not-send="true"
href="https://github.com/apple/swift/commit/1339b5403bbaf6205abb2bfdf7fabadef1aacc70#diff-1e8f8df8addd9510deea20d4bea2eda2"
            class="">https://github.com/apple/swift/commit/1339b5403bbaf6205abb2bfdf7fabadef1aacc70#diff-1e8f8df8addd9510deea20d4bea2eda2</a></div>
        <div><a moz-do-not-send="true"
href="https://github.com/apple/swift/commit/e3a4147ac94e55fcab1d14e949f572b53d9eb638#diff-1e8f8df8addd9510deea20d4bea2eda2"
            class="">https://github.com/apple/swift/commit/e3a4147ac94e55fcab1d14e949f572b53d9eb638#diff-1e8f8df8addd9510deea20d4bea2eda2</a></div>
        <div><br class="">
        </div>
        <div>That said, both of those patches are irrelevant to the
          discussion, because Argyrios removed the swift header and
          replaced it with the LLVM header when he checked it in.</div>
      </div>
    </blockquote>
    Just to be clear, you're saying that Apple owns the copyright on the
    entire file as posted for review and can thus relicense under the
    LLVM license?  If so, that would resolve the licensing concern.  In
    the future, let's make sure that gets mentioned in the review/commit
    thread to avoid confusion.<br>
    <br>
    With that, we're back to "let's post a patch and get it reviewed"
    per the normal process.  <br>
    <br>
    <br>
    <br>
    <br>
    <br>
    <blockquote
      cite="mid:E760DCF4-3FF0-458D-B1D6-11553C388C32@apple.com"
      type="cite">
      <div>
        <div><br class="">
        </div>
        <blockquote type="cite" class="">
          <div class="">
            <div dir="ltr" class="">
              <div class="gmail_quote">
                <blockquote class="gmail_quote" style="margin:0 0 0
                  .8ex;border-left:1px #ccc solid;padding-left:1ex">
                  <div style="word-wrap:break-word" class="">
                    <div class="">
                      <div class="">+ Chris, for comment.</div>
                    </div>
                  </div>
                </blockquote>
                <div class=""><br class="">
                </div>
                <div class="">Also, just to be clear (since I think my
                  original email wasn't terribly): I think something as
                  simple as this code review thread would have been fine
                  if you had waited for the code review, and made it
                  clear why it was OK to contribute (only Apple folks
                  have touched it, or whatever).</div>
                <div class=""><br class="">
                </div>
                <div class="">I'm not suggesting we need to have some
                  big or complex discussion. =] We have plenty of those
                  on harder subjects.</div>
              </div>
            </div>
          </div>
        </blockquote>
      </div>
      <div class=""><br class="">
      </div>
      <div class="">I agree that the header should get the normal patch
        review!</div>
      <div class=""><br class="">
      </div>
      <div class="">-Chris</div>
    </blockquote>
    <br>
  </body>
</html>