<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 12, 2016, at 11:23 AM, Philip Reames <<a href="mailto:listmail@philipreames.com" class="">listmail@philipreames.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
Er, if this didn't get reviewed, please revert it. This is not
merely poor form, but unacceptable for non-trivial changes in areas
for which you are not a regular contributor. <br class=""></div></div></blockquote><div><br class=""></div><div>+ Chandler, who is listed as ADT owner. I’d like to get his opinion if this needs to be reverted.</div><br class=""><blockquote type="cite" class=""><div class=""><div text="#000000" bgcolor="#FFFFFF" class="">
<br class="">
In particular, moving code between the swift repo and the LLVM repo
is not necessarily OK. At minimum, there needs to be some
discussion on llvm-dev of the licensing and implications.
Specifically, with the possible relicensing being discussed, adding
a bunch of unknown external authors (even if the current license is
compatible) might not be a good idea.<br class=""></div></div></blockquote><div><br class=""></div><div>I got permission internally and contributed the header under the LLVM license, I don’t think that whether it originated from swift repo or not makes any difference here.</div><div>If you could elaborate more on your concerns it would be helpful.</div><br class=""><blockquote type="cite" class=""><div class=""><div text="#000000" bgcolor="#FFFFFF" class="">
<br class="">
As such, please revert.<br class="">
<br class="">
Philip<br class="">
<br class="">
<div class="moz-cite-prefix">On 02/11/2016 11:33 PM, Argyrios
Kyrtzidis via llvm-commits wrote:<br class="">
</div>
<blockquote cite="mid:4F0B3F37-3FA9-4494-AB97-E6CD716A4721@apple.com" type="cite" class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<div class="">Sorry about that, I became a bit concerned this was
inconsequential enough that people would not really care to
provide feedback.</div>
<br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Feb 11, 2016, at 11:26 PM, David Blaikie <<a moz-do-not-send="true" href="mailto:dblaikie@gmail.com" class=""></a><a class="moz-txt-link-abbreviated" href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">It's generally considered poor form
to commit something without review, after asking for
it... </div>
<div class="gmail_extra"><br class="">
<div class="gmail_quote">On Thu, Feb 11, 2016 at 6:54 PM,
Argyrios Kyrtzidis via llvm-commits <span dir="ltr" class=""><<a moz-do-not-send="true" href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span>
wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I’ve
took the liberty of committing in r260652, since this
is general goodness and doesn’t affect existing code.<br class="">
<div class="">
<div class="h5"><br class="">
> On Feb 10, 2016, at 9:23 PM, Argyrios
Kyrtzidis <<a moz-do-not-send="true" href="mailto:kyrtzidis@apple.com" class="">kyrtzidis@apple.com</a>>
wrote:<br class="">
><br class="">
> Hi all,<br class="">
><br class="">
> The attached patch introduces ‘OptionSet’ in
llvm/ADT headers, which is a utility class that
makes it convenient to work with enumerators
representing bit options.<br class="">
><br class="">
> We have found it useful in the swift repo (<a moz-do-not-send="true" href="https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h" rel="noreferrer" target="_blank" class=""></a><a class="moz-txt-link-freetext" href="https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h">https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h</a>)
and I think it will be useful to other llvm
projects as well.<br class="">
><br class="">
> Let me know if you think it is ok to commit
in llvm repo.<br class="">
><br class="">
</div>
</div>
> <optionset.patch><br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a moz-do-not-send="true" href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a moz-do-not-send="true" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<br class="">
<pre wrap="" class="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></body></html>