<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Fri, Feb 12, 2016 at 11:32 AM Argyrios Kyrtzidis <<a href="mailto:kyrtzidis@apple.com">kyrtzidis@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><blockquote type="cite"><div>On Feb 12, 2016, at 11:23 AM, Philip Reames <<a href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>> wrote:</div><br><div>
<div text="#000000" bgcolor="#FFFFFF">
Er, if this didn't get reviewed, please revert it. This is not
merely poor form, but unacceptable for non-trivial changes in areas
for which you are not a regular contributor. <br></div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word"><div><div>+ Chandler, who is listed as ADT owner. I’d like to get his opinion if this needs to be reverted.</div></div></div></blockquote><div><br></div><div>It isn't up to the owner of ADT to decide whether this needs to be reverted. All I can do in that capacity is help you find a reviewer.</div><div><br></div><div>The community as a whole gets to say whether it needs to be reverted, and I think Philip has made a clear point here (which I completely agree with) and so I think you should probably revert. =]</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><div text="#000000" bgcolor="#FFFFFF">
<br>
In particular, moving code between the swift repo and the LLVM repo
is not necessarily OK. At minimum, there needs to be some
discussion on llvm-dev of the licensing and implications.
Specifically, with the possible relicensing being discussed, adding
a bunch of unknown external authors (even if the current license is
compatible) might not be a good idea.<br></div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word"><div><div>I got permission internally and contributed the header under the LLVM license, I don’t think that whether it originated from swift repo or not makes any difference here.</div><div>If you could elaborate more on your concerns it would be helpful.</div></div></div></blockquote><div><br></div><div>How do we know whether any other contributor to Swift authored some of the code in this file? Does Apple get copyright assignment for all Swift contributions? Only if Apple has copyright assignment for all contributions to Swift or only people from Apple have every contributed to this part of Swift is asking internally enough.</div><div><br></div><div>And since this is an open source project, it would seem polite (even if not necessary) to also ask the community rather than just asking internally. We don't all work at Apple. =/</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><div text="#000000" bgcolor="#FFFFFF">
<br>
As such, please revert.<br>
<br>
Philip<br>
<br>
<div>On 02/11/2016 11:33 PM, Argyrios
Kyrtzidis via llvm-commits wrote:<br>
</div>
<blockquote type="cite">
<div>Sorry about that, I became a bit concerned this was
inconsequential enough that people would not really care to
provide feedback.</div>
<br>
<div>
<blockquote type="cite">
<div>On Feb 11, 2016, at 11:26 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank"></a><a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div>
<br>
<div>
<div dir="ltr">It's generally considered poor form
to commit something without review, after asking for
it... </div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Feb 11, 2016 at 6:54 PM,
Argyrios Kyrtzidis via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I’ve
took the liberty of committing in r260652, since this
is general goodness and doesn’t affect existing code.<br>
<div>
<div><br>
> On Feb 10, 2016, at 9:23 PM, Argyrios
Kyrtzidis <<a href="mailto:kyrtzidis@apple.com" target="_blank">kyrtzidis@apple.com</a>>
wrote:<br>
><br>
> Hi all,<br>
><br>
> The attached patch introduces ‘OptionSet’ in
llvm/ADT headers, which is a utility class that
makes it convenient to work with enumerators
representing bit options.<br>
><br>
> We have found it useful in the swift repo (<a href="https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h" rel="noreferrer" target="_blank"></a><a href="https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h" target="_blank">https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h</a>)
and I think it will be useful to other llvm
projects as well.<br>
><br>
> Let me know if you think it is ok to commit
in llvm repo.<br>
><br>
</div>
</div>
> <optionset.patch><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
llvm-commits mailing list
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</div>
</div></blockquote></div></div></blockquote></div></div>