<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 11, 2016 at 10:27 AM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This looks like a static/dynamic C runtime mismatch. I configured my checkout locally to use the static runtime, and the buildbot is using the default of dynamic. On the buildbot, the profile library is getting linked against msvcrt and the test code is linked against libcmt. Linking these objects together will fail.<div><br></div><div>If we really want the coverage library to work on Windows, we either need to avoid use of the CRT or provide two versions, one dynamic one static. Last of all we could make the profiling library into a DLL.</div><div><br></div><div>Anyway, we don't currently run test/profile on Windows at all, so let's disable this test completely for now.</div></div></blockquote><div><br></div><div>OK, r260561.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 11, 2016 at 10:16 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Actually, it's still failing on the bot: <a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/16985/steps/run%20tests/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-windows/builds/16985/steps/run%20tests/logs/stdio</a></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Wed, Feb 10, 2016 at 6:02 PM, Reid Kleckner via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Wed Feb 10 20:02:56 2016<br>
New Revision: 260481<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=260481&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=260481&view=rev</a><br>
Log:<br>
Un-XFAIL a passing test on Windows<br>
<br>
Modified:<br>
    compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc<br>
<br>
Modified: compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc?rev=260481&r1=260480&r2=260481&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc?rev=260481&r1=260480&r2=260481&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc (original)<br>
+++ compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc Wed Feb 10 20:02:56 2016<br>
@@ -1,6 +1,6 @@<br>
 // RUN: %clangxx_asan -coverage -O0 %s -o %t<br>
 // RUN: %env_asan_opts=check_initialization_order=1 %run %t 2>&1 | FileCheck %s<br>
-// XFAIL: android,win32<br>
+// XFAIL: android<br>
 #include <stdio.h><br>
 int foo() { return 1; }<br>
 int XXX = foo();<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</font></span></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div></div>