<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Sorry about that, I became a bit concerned this was inconsequential enough that people would not really care to provide feedback.</div><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 11, 2016, at 11:26 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">It's generally considered poor form to commit something without review, after asking for it... </div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Feb 11, 2016 at 6:54 PM, Argyrios Kyrtzidis via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I’ve took the liberty of committing in r260652, since this is general goodness and doesn’t affect existing code.<br class="">
<div class=""><div class="h5"><br class="">
> On Feb 10, 2016, at 9:23 PM, Argyrios Kyrtzidis <<a href="mailto:kyrtzidis@apple.com" class="">kyrtzidis@apple.com</a>> wrote:<br class="">
><br class="">
> Hi all,<br class="">
><br class="">
> The attached patch introduces ‘OptionSet’ in llvm/ADT headers, which is a utility class that makes it convenient to work with enumerators representing bit options.<br class="">
><br class="">
> We have found it useful in the swift repo (<a href="https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h" rel="noreferrer" target="_blank" class="">https://github.com/apple/swift/blob/master/include/swift/Basic/OptionSet.h</a>) and I think it will be useful to other llvm projects as well.<br class="">
><br class="">
> Let me know if you think it is ok to commit in llvm repo.<br class="">
><br class="">
</div></div>> <optionset.patch><br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>