<div dir="ltr">I doubt we're terribly consistent about that (I see 7 cases of "return EXIT_SUCCESS" across all of llvm/clang - I imagine we have many more main functions than that... <br><br>Also, in C++ you can just omit it entirely and let main return - it's implicitly return 0.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 10, 2016 at 3:56 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Wed Feb 10 17:56:18 2016<br>
New Revision: 260470<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=260470&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=260470&view=rev</a><br>
Log:<br>
[llvm-nm] Minor style change. Prefer EXIT_SUCCESS over 0.<br>
<br>
Modified:<br>
llvm/trunk/tools/llvm-nm/llvm-nm.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-nm/llvm-nm.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=260470&r1=260469&r2=260470&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=260470&r1=260469&r2=260470&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp (original)<br>
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp Wed Feb 10 17:56:18 2016<br>
@@ -1312,5 +1312,5 @@ int main(int argc, char **argv) {<br>
if (HadError)<br>
return 1;<br>
<br>
- return 0;<br>
+ return EXIT_SUCCESS;<br>
}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>