<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 9, 2016 at 2:37 PM, David Majnemer via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">majnemer added inline comments.<br>
<span class=""><br>
================<br>
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:569<br>
@@ +568,3 @@<br>
+  OS.AddComment("TypeIndex");<br>
+  OS.EmitIntValue(TypeIndex::Int32().getIndex(), 4);<br>
+  OS.AddComment("Flags");<br>
----------------<br>
</span><span class="">dblaikie wrote:<br>
> Some comments here might not go astray (what is the format of these records you're emitting (maybe a broad comment at the top describing the format overall, then details on each field))<br>
><br>
> Specifically I don't know what the 4 here and 2, below (flags), are.<br>
</span>They (4 and 2) are the size of the value in bytes.  Otherwise, `EmitIntValue` wouldn't know how much data to emit.<br></blockquote><div><br>Ah... right. (thanks!)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="http://reviews.llvm.org/D16931" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16931</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>