<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 9, 2016 at 4:31 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">That's a violation of the ABI, no?</div></blockquote><div><br></div><div>I'm not sure, but does it matter? Basically any object file produced by clang>=3.4 with debug info will have this if the code uses thread-locals. These files are out there in the wild and ToT clang still produces them.</div><div><br></div><div>-- Sean Silva</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 8, 2016 at 3:05 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Feb 3, 2016 at 11:07 AM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br></span><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: ruiu<br>
Date: Wed Feb  3 13:07:56 2016<br>
New Revision: 259679<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=259679&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=259679&view=rev</a><br>
Log:<br>
ELF: Remove dead code.<br>
<br>
R_X86_64_DTPOFF64 relocs are for the dynamic linker.<br>
Static linkers create them but don't consume them.<br></blockquote><div><br></div></span><div>Clang produces these in debug info and now LLD dies on trivial inputs like the object file produced with -g from `__thread long i;`. (full example here: <a href="http://reviews.llvm.org/P1652" target="_blank">http://reviews.llvm.org/P1652</a>)</div><span><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Modified:<br>
    lld/trunk/ELF/Target.cpp<br>
<br>
Modified: lld/trunk/ELF/Target.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=259679&r1=259678&r2=259679&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=259679&r1=259678&r2=259679&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Target.cpp (original)<br>
+++ lld/trunk/ELF/Target.cpp Wed Feb  3 13:07:56 2016<br>
@@ -873,9 +873,6 @@ void X86_64TargetInfo::relocateOne(uint8<br>
   case R_X86_64_DTPOFF32:<br>
     write32le(Loc, SA);<br>
     break;<br>
-  case R_X86_64_DTPOFF64:<br>
-    write64le(Loc, SA);<br>
-    break;<br>
   case R_X86_64_GOTPCREL:<br>
   case R_X86_64_PC32:<br>
   case R_X86_64_PLT32:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div>