<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 5, 2016 at 2:07 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Fri Feb  5 16:07:09 2016<br>
New Revision: 259937<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=259937&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=259937&view=rev</a><br>
Log:<br>
[llvm-nm] Transform a switch() statement in a pair of if(s).<br>
<br>
This is more uniform wrt what other tools do and makes the code<br>
a little bit more readable.<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-nm/llvm-nm.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-nm/llvm-nm.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=259937&r1=259936&r2=259937&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=259937&r1=259936&r2=259937&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp (original)<br>
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp Fri Feb  5 16:07:09 2016<br>
@@ -1267,15 +1267,10 @@ int main(int argc, char **argv) {<br>
     PrintAddress = false;<br>
   if (OutputFormat == sysv || SizeSort)<br>
     PrintSize = true;<br>
-<br>
-  switch (InputFilenames.size()) {<br>
-  case 0:<br>
+  if (InputFilenames.size() == 0)<br></blockquote><div><br></div><div>Prefer 'empty' rather than size == 0</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
     InputFilenames.push_back("a.out");<br>
-  case 1:<br>
-    break;<br>
-  default:<br>
+  if (InputFilenames.size() > 1)<br>
     MultipleFiles = true;<br>
-  }<br>
<br>
   for (unsigned i = 0; i < ArchFlags.size(); ++i) {<br>
     if (ArchFlags[i] == "all") {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>