<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Feb 4, 2016 at 3:46 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Thu, Feb 4, 2016 at 3:39 PM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: ruiu<br>
Date: Thu Feb  4 17:39:33 2016<br>
New Revision: 259847<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=259847&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=259847&view=rev</a><br>
Log:<br>
Do not round uintX_t to uint32_t.<br>
<br>
On 64-bit computers, this value can be larger than UINT32_MAX.<br></blockquote><div><br></div></span><div>Test case? (I'm assuming this is observable in the output in some way? (when linking 64 bit executables (or is it really a matter of the host hardware?)?))</div></div></div></div></blockquote><div><br></div><div>It should be observable when you link a >4GB binary. Don't know how to observe other than that way. (I didn't see that, but I noticed that the code was theoretically wrong when I happened to be reading that.)</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Modified:<br>
    lld/trunk/ELF/OutputSections.h<br>
<br>
Modified: lld/trunk/ELF/OutputSections.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.h?rev=259847&r1=259846&r2=259847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.h?rev=259847&r1=259846&r2=259847&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/OutputSections.h (original)<br>
+++ lld/trunk/ELF/OutputSections.h Thu Feb  4 17:39:33 2016<br>
@@ -130,7 +130,7 @@ public:<br>
   // the number of reserved entries. This method is MIPS-specific.<br>
   unsigned getMipsLocalEntriesNum() const;<br>
<br>
-  uint32_t getLocalTlsIndexVA() { return Base::getVA() + LocalTlsIndexOff; }<br>
+  uintX_t getLocalTlsIndexVA() { return Base::getVA() + LocalTlsIndexOff; }<br>
<br>
 private:<br>
   std::vector<const SymbolBody *> Entries;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>