<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 3, 2016 at 11:34 AM, Reid Kleckner via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Wed Feb 3 13:34:28 2016<br>
New Revision: 259683<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=259683&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=259683&view=rev</a><br>
Log:<br>
Minor performance tweaks to llvm-tblgen (and a few that might be a good idea)<br>
<br>
Summary:<br>
This patch adds a reserve call to an expensive function<br>
(`llvm::LoadIntrinsics`), and may fix a few other low hanging<br>
performance fruit (I've put them in comments for now, so we can<br>
discuss).<br>
<br>
**Motivation:**<br>
<br>
As I'm sure other developers do, when I build LLVM, I build the entire<br>
project with the same config (`Debug`, `MinSizeRel`, `Release`, or<br>
`RelWithDebInfo`). However, the `Debug` config also builds llvm-tblgen<br>
in `Debug` mode. Later build steps that run llvm-tblgen then can<br>
actually be the slowest steps in the entire build. Nobody likes slow<br>
builds.<br>
<br>
Reviewers: rnk, dblaikie<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D16832" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16832</a><br>
<br>
Patch by Alexander G. Riccio<br>
<br>
Modified:<br>
llvm/trunk/include/llvm/TableGen/Record.h<br>
llvm/trunk/utils/TableGen/CodeGenInstruction.cpp<br>
llvm/trunk/utils/TableGen/CodeGenTarget.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/TableGen/Record.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/TableGen/Record.h?rev=259683&r1=259682&r2=259683&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/TableGen/Record.h?rev=259683&r1=259682&r2=259683&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/TableGen/Record.h (original)<br>
+++ llvm/trunk/include/llvm/TableGen/Record.h Wed Feb 3 13:34:28 2016<br>
@@ -1307,9 +1307,14 @@ public:<br>
}<br>
<br>
bool isSubClassOf(StringRef Name) const {<br>
- for (const auto &SCPair : SuperClasses)<br>
- if (SCPair.first->getNameInitAsString() == Name)<br>
+ for (const auto &SCPair : SuperClasses) {<br>
+ if (const auto *SI = dyn_cast<StringInit>(SCPair.first->getNameInit())) {<br></blockquote><div><br></div><div>This is a bit more novel/noteworthy & might merit a comment about why we're using dyn_cast to do the same work as getNameInitAsString. Perhaps.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ if (SI->getValue() == Name)<br>
+ return true;<br>
+ } else if (SCPair.first->getNameInitAsString() == Name) {<br>
return true;<br>
+ }<br>
+ }<br>
return false;<br>
}<br>
<br>
<br>
Modified: llvm/trunk/utils/TableGen/CodeGenInstruction.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenInstruction.cpp?rev=259683&r1=259682&r2=259683&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenInstruction.cpp?rev=259683&r1=259682&r2=259683&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/TableGen/CodeGenInstruction.cpp (original)<br>
+++ llvm/trunk/utils/TableGen/CodeGenInstruction.cpp Wed Feb 3 13:34:28 2016<br>
@@ -49,7 +49,9 @@ CGIOperandList::CGIOperandList(Record *R<br>
<br>
unsigned MIOperandNo = 0;<br>
std::set<std::string> OperandNames;<br>
- for (unsigned i = 0, e = InDI->getNumArgs()+OutDI->getNumArgs(); i != e; ++i){<br>
+ unsigned e = InDI->getNumArgs() + OutDI->getNumArgs();<br>
+ OperandList.reserve(e);<br>
+ for (unsigned i = 0; i != e; ++i){<br>
Init *ArgInit;<br>
std::string ArgName;<br>
if (i < NumDefs) {<br>
<br>
Modified: llvm/trunk/utils/TableGen/CodeGenTarget.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenTarget.cpp?rev=259683&r1=259682&r2=259683&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenTarget.cpp?rev=259683&r1=259682&r2=259683&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/TableGen/CodeGenTarget.cpp (original)<br>
+++ llvm/trunk/utils/TableGen/CodeGenTarget.cpp Wed Feb 3 13:34:28 2016<br>
@@ -441,6 +441,7 @@ std::vector<CodeGenIntrinsic> llvm::Load<br>
std::vector<Record*> I = RC.getAllDerivedDefinitions("Intrinsic");<br>
<br>
std::vector<CodeGenIntrinsic> Result;<br>
+ Result.reserve(I.size());<br>
<br>
for (unsigned i = 0, e = I.size(); i != e; ++i) {<br>
bool isTarget = I[i]->getValueAsBit("isTarget");<br>
@@ -448,7 +449,7 @@ std::vector<CodeGenIntrinsic> llvm::Load<br>
Result.push_back(CodeGenIntrinsic(I[i]));<br>
}<br>
std::sort(Result.begin(), Result.end(),<br>
- [](CodeGenIntrinsic LHS, CodeGenIntrinsic RHS) {<br>
+ [](const CodeGenIntrinsic& LHS, const CodeGenIntrinsic& RHS) {<br>
return LHS.Name < RHS.Name;<br>
});<br>
return Result;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>