<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Feb 3, 2016 at 12:37 PM, Galina Kistanova via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div>While we are on the subject, I'd like to validate this builder goals.<br><br></div>This builder would build on Windows lld + minimum required dependencies natively by Visual Studio. Then it would run lld tests. We want it to be a fast builder, ideally building every single commit.<br></div><br></div>Currently it builds by Visual Studio 2013, but I'm going to upgrade it to Visual Studio 2015, unless somebody sees a special value of building by VS 2013.<br><br></div>Does this sound reasonable?<br></div>Anything to do differently?<br></div></div></div></blockquote><div><br></div><div>Sounds good to me. (I'm not using VS2015 yet, but happy to migrate.)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div>Thanks<br><br></div>Galina<div><div class="h5"><br><br><br><div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 2, 2016 at 7:04 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Tue, Feb 2, 2016 at 6:08 PM, Galina Kistanova <span dir="ltr"><<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Sean,<br><br>Sorry for the delay. It was busy couple days.<br><br>That particular builder was not intended to run tests. Back when it was setup the lld test suite didn't run well on Windows.<br><br>Though, you are right. I'm about to convert it to build with ninja and run tests. If everything will go well, it will be ready tomorrow. <br></div></blockquote><div><br></div></span><div>Thanks!</div><span><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span><div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br>Thanks<span><font color="#888888"><br><br>Galina</font></span><div><div><br><br><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 29, 2016 at 7:44 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Mon, Jun 10, 2013 at 3:22 PM, Galina Kistanova <span dir="ltr"><<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: gkistanova<br>
Date: Mon Jun 10 17:22:01 2013<br>
New Revision: 183702<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=183702&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=183702&view=rev</a><br>
Log:<br>
Added new lld builder, slave, LLDWinBuildFactory.<br>
<br>
Modified:<br>
zorg/trunk/buildbot/osuosl/master/config/builders.py<br>
zorg/trunk/buildbot/osuosl/master/config/slaves.py<br>
zorg/trunk/zorg/buildbot/builders/LLDBuilder.py<br>
<br>
Modified: zorg/trunk/buildbot/osuosl/master/config/builders.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/buildbot/osuosl/master/config/builders.py?rev=183702&r1=183701&r2=183702&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/buildbot/osuosl/master/config/builders.py?rev=183702&r1=183701&r2=183702&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/buildbot/osuosl/master/config/builders.py (original)<br>
+++ zorg/trunk/buildbot/osuosl/master/config/builders.py Mon Jun 10 17:22:01 2013<br>
@@ -599,6 +599,13 @@ def _get_lld_builders():<br>
'builddir':"lld-x86_64-darwin11",<br>
'factory': LLDBuilder.getLLDBuildFactory(),<br>
'category' : 'lld'},<br>
+<br>
+ {'name': "lld-x86_64-win7",<br>
+ 'slavenames' :["as-bldslv4"],<br>
+ 'builddir':"lld-x86_64-win7",<br>
+ 'factory': LLDBuilder.getLLDWinBuildFactory(clean=False),<br>
+ 'category' : 'lld'},<br>
+<br>
]<br>
<br>
# Sanitizer builders.<br>
<br>
Modified: zorg/trunk/buildbot/osuosl/master/config/slaves.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/buildbot/osuosl/master/config/slaves.py?rev=183702&r1=183701&r2=183702&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/buildbot/osuosl/master/config/slaves.py?rev=183702&r1=183701&r2=183702&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/buildbot/osuosl/master/config/slaves.py (original)<br>
+++ zorg/trunk/buildbot/osuosl/master/config/slaves.py Mon Jun 10 17:22:01 2013<br>
@@ -202,6 +202,9 @@ def get_build_slaves():<br>
# Ubuntu x86-64, 12x Intel(R) Xeon(R) CPU X5650 @ 2.67GHz<br>
create_slave("sanitizer-buildbot1", properties={'jobs': 8}, max_builds=1),<br>
<br>
+ # Windows 7 Professional x64<br>
+ create_slave("as-bldslv4", properties={'jobs' : 2}, max_builds=1),<br>
+<br>
# Defunct.<br>
# Pentium Dual CPU T3400 @ 2.1GHz<br>
#create_slave("dumitrescu1", properties={'jobs' : 2}, max_builds=1),<br>
<br>
Modified: zorg/trunk/zorg/buildbot/builders/LLDBuilder.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/LLDBuilder.py?rev=183702&r1=183701&r2=183702&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/LLDBuilder.py?rev=183702&r1=183701&r2=183702&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/zorg/buildbot/builders/LLDBuilder.py (original)<br>
+++ zorg/trunk/zorg/buildbot/builders/LLDBuilder.py Mon Jun 10 17:22:01 2013<br>
@@ -3,7 +3,7 @@ import os<br>
import buildbot<br>
import buildbot.process.factory<br>
from buildbot.steps.source import SVN, Git<br>
-from buildbot.steps.shell import Configure, ShellCommand<br>
+from buildbot.steps.shell import Configure, ShellCommand, SetProperty<br>
from buildbot.process.properties import WithProperties<br>
<br>
def getLLDBuildFactory(<br>
@@ -74,3 +74,91 @@ def getLLDBuildFactory(<br>
workdir=llvm_objdir))<br>
<br>
return f<br>
+<br>
+<br>
+def getLLDWinBuildFactory(<br>
+ clean = True):<br>
+<br>
+ llvm_srcdir = "llvm.src"<br>
+ llvm_objdir = "llvm.obj"<br>
+<br>
+ f = buildbot.process.factory.BuildFactory()<br>
+<br>
+ # Get LLVM and Lld<br>
+ f.addStep(SVN(name='svn-llvm',<br>
+ mode='update',<br>
+ baseURL='<a href="http://llvm.org/svn/llvm-project/llvm/" rel="noreferrer" target="_blank">http://llvm.org/svn/llvm-project/llvm/</a>',<br>
+ defaultBranch='trunk',<br>
+ workdir=llvm_srcdir))<br>
+ f.addStep(SVN(name='svn-lld',<br>
+ mode='update',<br>
+ baseURL='<a href="http://llvm.org/svn/llvm-project/lld/" rel="noreferrer" target="_blank">http://llvm.org/svn/llvm-project/lld/</a>',<br>
+ defaultBranch='trunk',<br>
+ workdir='%s/tools/lld' % llvm_srcdir))<br>
+<br>
+ # Clean directory, if requested.<br>
+ if clean:<br>
+ f.addStep(ShellCommand(name="rm-llvm_objdir",<br>
+ command=["if", "exist", llvm_objdir,<br>
+ "rmdir", "/S", "/Q", llvm_objdir],<br>
+ haltOnFailure=True,<br>
+ description=["rm build dir", "llvm"],<br>
+ workdir="."))<br>
+<br>
+ f.addStep(ShellCommand(name="create-build-dir",<br>
+ command=["if", "not", "exist", llvm_objdir,<br>
+ "mkdir", llvm_objdir],<br>
+ haltOnFailure=True,<br>
+ description=["create build dir"],<br>
+ workdir="."))<br>
+<br>
+ # Is CMake configuration already done?<br>
+ checkCMakeCommand = [<br>
+ "dir", "CMakeCache.txt", ">", "NUL",<br>
+ "&&", "echo", "Yes",<br>
+ "||", "echo", "No", ">", "NUL"]<br>
+<br>
+ # Note: ShellCommand does not pass the params with special symbols right.<br>
+ # The " ".join is a workaround for this bug.<br>
+ f.addStep(SetProperty(name="CMake_done",<br>
+ workdir=llvm_objdir,<br>
+ command=WithProperties(" ".join(checkCMakeCommand)),<br>
+ #"cmd", "/C",<br>
+ #" ".join(checkCMakeCommand)],<br>
+ haltOnFailure=True,<br>
+ description=["check CMake_done"],<br>
+ property="CMake_done"))<br>
+<br>
+ # Create configuration files with cmake<br>
+ cmakeCommand = [<br>
+ "cmake",<br>
+ "-DCMAKE_BUILD_TYPE=Release",<br>
+ "-DLLVM_TARGETS_TO_BUILD=X86",<br>
+ "../%s" % llvm_srcdir]<br>
+<br>
+ f.addStep(ShellCommand(<br>
+ name="cmake-configure",<br>
+ description=["cmake configure"],<br>
+ haltOnFailure=True,<br>
+ command=WithProperties(" ".join(cmakeCommand)),<br>
+ workdir=llvm_objdir,<br>
+ doStepIf=lambda step: step.build.getProperty("CMake_done") != "Yes"))<br>
+<br>
+ # Build Lld<br>
+ f.addStep(ShellCommand(name="build_Lld",<br>
+ command=["msbuild",<br>
+ #"/maxcpucount:1",<br>
+ "/verbosity:minimal",<br>
+ "/property:Configuration=Release",<br>
+ "ALL_BUILD.vcxproj"],<br>
+ haltOnFailure=True,<br>
+ description=["build lld"],<br>
+ workdir=llvm_objdir))<br>
+ # Test Lld<br>
+ #f.addStep(ShellCommand(name="test_lld",<br>
+ # command=["make", "lld-test"],<br>
+ # haltOnFailure=True,<br>
+ # description=["test lld"],<br>
+ # workdir=llvm_objdir))<br></blockquote><div><br></div></div></div><div>Why does this bot not run tests?</div><span><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span><span><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
+ return f<br>
\ No newline at end of file<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>