<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 1, 2016 at 9:51 AM, Matt Arsenault via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">arsenm created this revision.<br>
arsenm added a reviewer: tstellarAMD.<br>
arsenm added a subscriber: llvm-commits.<br>
Herald added a subscriber: arsenm.<br>
<br>
<a href="http://reviews.llvm.org/D16774" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16774</a><br>
<br>
Files:<br>
  lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp<br>
<br>
Index: lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp<br>
===================================================================<br>
--- lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp<br>
+++ lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp<br>
@@ -402,7 +402,10 @@<br>
 static bool collectUsesWithPtrTypes(Value *Val, std::vector<Value*> &WorkList) {<br>
   bool Success = true;<br>
   for (User *User : Val->users()) {<br>
-    if(std::find(WorkList.begin(), WorkList.end(), User) != WorkList.end())<br>
+    if (!Success)<br>
+      return false;<br>
+<br>
+    if (std::find(WorkList.begin(), WorkList.end(), User) != WorkList.end())<br>
       continue;<br>
     if (CallInst *CI = dyn_cast<CallInst>(User)) {<br>
       // TODO: We might be able to handle some cases where the callee is a<br>
@@ -429,10 +432,10 @@<br>
       continue;<br>
<br>
     WorkList.push_back(User);<br>
-<br>
-    Success &= collectUsesWithPtrTypes(User, WorkList);<br>
+    Success = collectUsesWithPtrTypes(User, WorkList);<br></blockquote><div><br></div><div>Why not just drop the Success variable entirely and return from here:<br><br>if (!collectUsesWithPtrTypes(...))<br>  return false<br><br>Or, possibly better yet:<br><br>return llvm::all_of(Val->users(), [&](User *User) {<br>  ...<br>  return collectUsesWithPtrTypes(User, WorkList);<br>});</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   }<br>
-  return Success;<br>
+<br>
+  return true;<br>
 }<br>
<br>
 void AMDGPUPromoteAlloca::visitAlloca(AllocaInst &I) {<br>
<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>