Hi,<br><br>I'm not happy with the test changes; it was checking that at least the comment said 'trap' - what happens now if we regress and the .inst is t even emitted for that testcase?<br><br>James<br><div class="gmail_quote"><div dir="ltr">On Fri, 29 Jan 2016 at 10:27, Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL259182: [ARM] Emit trap instruction using .inst directive (authored by alelab01).<br>
<br>
Changed prior to commit:<br>
  <a href="http://reviews.llvm.org/D16684?vs=46269&id=46367#toc" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16684?vs=46269&id=46367#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D16684" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16684</a><br>
<br>
Files:<br>
  llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp<br>
  llvm/trunk/test/CodeGen/ARM/debugtrap.ll<br>
  llvm/trunk/test/CodeGen/ARM/trap.ll<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>