<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 27, 2016 at 4:31 PM, Mike Aizatsky via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aizatsky<br>
Date: Wed Jan 27 18:31:49 2016<br>
New Revision: 259005<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=259005&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=259005&view=rev</a><br>
Log:<br>
GetArgv returns null on widnows, do not crash<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc?rev=259005&r1=259004&r2=259005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc?rev=259005&r1=259004&r2=259005&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc Wed Jan 27 18:31:49 2016<br>
@@ -811,8 +811,10 @@ void CoverageData::DumpOffsets() {<br>
<br>
   InternalMmapVector<char *> sancov_argv(module_name_vec.size() + 2);<br>
   sancov_argv.push_back(FindPathToBinary(common_flags()->sancov_path));<br>
-  sancov_argv.push_back(internal_strdup("-obj"));<br>
-  sancov_argv.push_back(internal_strdup(GetArgv()[0]));<br>
+  if (GetArgv() != nullptr) {<br></blockquote><div><br>Perhaps:<br><br>if (auto *GA = getArgv())<br>  ... GA[0] ...<br><br>instead?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+    sancov_argv.push_back(internal_strdup("-obj"));<br>
+    sancov_argv.push_back(internal_strdup(GetArgv()[0]));<br>
+  }<br>
   sancov_argv.push_back(internal_strdup("-html-report"));<br>
   auto argv_deleter = at_scope_exit([&] {<br>
     for (uptr i = 0; i < sancov_argv.size(); ++i) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>