<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Sure. What’s the criteria for “regularity”? Is it alphabetically sorting?<div class="">(I kept the original order unless I’m mistaken).</div><div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On Jan 26, 2016, at 1:35 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">I'll let Duncan review this more, but as a quick side note - would you mind making the ordering of arguments a little more regular? Name, File, Line, Scope or something?<div class=""><br class=""></div><div class="">-eric</div></div><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr" class="">On Tue, Jan 26, 2016 at 12:43 PM Mehdi AMINI via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">joker.eph updated this revision to Diff 46036.<br class="">joker.eph added a comment.<br class=""><br class="">Applies to other metadata types<br class=""><br class=""><br class=""><a href="http://reviews.llvm.org/D16571" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D16571</a><br class=""><br class="">Files:<br class=""> <span class="Apple-converted-space"> </span>lib/IR/LLVMContextImpl.h<br class=""><br class="">Index: lib/IR/LLVMContextImpl.h<br class="">===================================================================<br class="">--- lib/IR/LLVMContextImpl.h<br class="">+++ lib/IR/LLVMContextImpl.h<br class="">@@ -365,8 +365,7 @@<br class=""> <span class="Apple-converted-space"> </span>ExtraData == RHS->getRawExtraData();<br class=""> }<br class=""> unsigned getHashValue() const {<br class="">- return hash_combine(Tag, Name, File, Line, Scope, BaseType, SizeInBits,<br class="">- AlignInBits, OffsetInBits, Flags, ExtraData);<br class="">+ return hash_combine(Name, File, Line, Scope, BaseType);<br class=""> }<br class=""> };<br class=""><br class="">@@ -422,9 +421,7 @@<br class=""> <span class="Apple-converted-space"> </span>Identifier == RHS->getRawIdentifier();<br class=""> }<br class=""> unsigned getHashValue() const {<br class="">- return hash_combine(Tag, Name, File, Line, Scope, BaseType, SizeInBits,<br class="">- AlignInBits, OffsetInBits, Flags, Elements, RuntimeLang,<br class="">- VTableHolder, TemplateParams, Identifier);<br class="">+ return hash_combine(Name, File, Line, Scope, SizeInBits, Elements);<br class=""> }<br class=""> };<br class=""><br class="">@@ -519,10 +516,7 @@<br class=""> <span class="Apple-converted-space"> </span>Variables == RHS->getRawVariables();<br class=""> }<br class=""> unsigned getHashValue() const {<br class="">- return hash_combine(Scope, Name, LinkageName, File, Line, Type,<br class="">- IsLocalToUnit, IsDefinition, ScopeLine, ContainingType,<br class="">- Virtuality, VirtualIndex, Flags, IsOptimized,<br class="">- TemplateParams, Declaration, Variables);<br class="">+ return hash_combine(Scope, File, Type, Line);<br class=""> }<br class=""> };<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></blockquote></div></div></blockquote></div><br class=""></div></body></html>