<div dir="ltr">I usually go with "group according to type", so things like file, line, etc should be grouped and seem more important than scope, but name is most important so put that first?<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 26, 2016 at 1:38 PM Mehdi Amini <<a href="mailto:mehdi.amini@apple.com">mehdi.amini@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Sure. What’s the criteria for “regularity”? Is it alphabetically sorting?<div>(I kept the original order unless I’m mistaken).</div><div><br></div><div>— </div></div><div style="word-wrap:break-word"><div>Mehdi</div></div><div style="word-wrap:break-word"><div><br></div><div><div><blockquote type="cite"><div>On Jan 26, 2016, at 1:35 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:</div><br><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">I'll let Duncan review this more, but as a quick side note - would you mind making the ordering of arguments a little more regular? Name, File, Line, Scope or something?<div><br></div><div>-eric</div></div><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div dir="ltr">On Tue, Jan 26, 2016 at 12:43 PM Mehdi AMINI via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">joker.eph updated this revision to Diff 46036.<br>joker.eph added a comment.<br><br>Applies to other metadata types<br><br><br><a href="http://reviews.llvm.org/D16571" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16571</a><br><br>Files:<br> <span> </span>lib/IR/LLVMContextImpl.h<br><br>Index: lib/IR/LLVMContextImpl.h<br>===================================================================<br>--- lib/IR/LLVMContextImpl.h<br>+++ lib/IR/LLVMContextImpl.h<br>@@ -365,8 +365,7 @@<br>           <span> </span>ExtraData == RHS->getRawExtraData();<br>   }<br>   unsigned getHashValue() const {<br>-    return hash_combine(Tag, Name, File, Line, Scope, BaseType, SizeInBits,<br>-                        AlignInBits, OffsetInBits, Flags, ExtraData);<br>+    return hash_combine(Name, File, Line, Scope, BaseType);<br>   }<br> };<br><br>@@ -422,9 +421,7 @@<br>           <span> </span>Identifier == RHS->getRawIdentifier();<br>   }<br>   unsigned getHashValue() const {<br>-    return hash_combine(Tag, Name, File, Line, Scope, BaseType, SizeInBits,<br>-                        AlignInBits, OffsetInBits, Flags, Elements, RuntimeLang,<br>-                        VTableHolder, TemplateParams, Identifier);<br>+    return hash_combine(Name, File, Line, Scope, SizeInBits, Elements);<br>   }<br> };<br><br>@@ -519,10 +516,7 @@<br>           <span> </span>Variables == RHS->getRawVariables();<br>   }<br>   unsigned getHashValue() const {<br>-    return hash_combine(Scope, Name, LinkageName, File, Line, Type,<br>-                        IsLocalToUnit, IsDefinition, ScopeLine, ContainingType,<br>-                        Virtuality, VirtualIndex, Flags, IsOptimized,<br>-                        TemplateParams, Declaration, Variables);<br>+    return hash_combine(Scope, File, Type, Line);<br>   }<br> };<br><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></blockquote></div></div></blockquote></div><br></div></div></blockquote></div>