<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 12:20 AM, George Rimar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grimar<br>
Date: Mon Jan 25 02:20:16 2016<br>
New Revision: 258670<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258670&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258670&view=rev</a><br>
Log:<br>
Use of assert instead of llvm_unreachable in EhFrameHeader<ELFT>::assignEhFrame().<br>
<br>
Modified:<br>
    lld/trunk/ELF/OutputSections.cpp<br>
<br>
Modified: lld/trunk/ELF/OutputSections.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.cpp?rev=258670&r1=258669&r2=258670&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.cpp?rev=258670&r1=258669&r2=258670&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/OutputSections.cpp (original)<br>
+++ lld/trunk/ELF/OutputSections.cpp Mon Jan 25 02:20:16 2016<br>
@@ -862,7 +862,7 @@ template <class ELFT> void EhFrameHeader<br>
 template <class ELFT><br>
 void EhFrameHeader<ELFT>::assignEhFrame(EHOutputSection<ELFT> *Sec) {<br>
   if (this->Sec && this->Sec != Sec)<br>
-    llvm_unreachable("multiple .eh_frame sections not supported for .eh_frame_hdr");<br>
+    assert("multiple .eh_frame sections not supported for .eh_frame_hdr");<br></blockquote><div><br></div><div>This assertion will never fail because converting a string to a boolean is always true (a non-null pointer is always true)<br><br>This should be:<br><br>assert((!this->Sec || this->Sec == Sec) && "multiple .eh_frame sections ... ");</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   Live = Config->EhFrameHdr;<br>
   this->Sec = Sec;<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>