<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jan 24, 2016 at 6:17 AM, Tobias Grosser via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grosser<br>
Date: Sun Jan 24 08:16:59 2016<br>
New Revision: 258660<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258660&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258660&view=rev</a><br>
Log:<br>
BlockGenerators: Avoid redundant map lookup [NFC]<br>
<br>
Modified:<br>
    polly/trunk/lib/CodeGen/BlockGenerators.cpp<br>
<br>
Modified: polly/trunk/lib/CodeGen/BlockGenerators.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=258660&r1=258659&r2=258660&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=258660&r1=258659&r2=258660&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/lib/CodeGen/BlockGenerators.cpp (original)<br>
+++ polly/trunk/lib/CodeGen/BlockGenerators.cpp Sun Jan 24 08:16:59 2016<br>
@@ -338,8 +338,8 @@ Value *BlockGenerator::getOrCreateAlloca<br>
<br>
   auto Addr = Map[ScalarBase];<br>
<br>
-  if (GlobalMap.count(Addr))<br>
-    return GlobalMap[Addr];<br>
+  if (auto NewAddr = GlobalMap.lookup(Addr))<br></blockquote><div><br></div><div>Probably best to include the '*' in auto here (if I'm understanding the code correctly, auto is binding to Instruction* here) to make it clear that it's a pointer (& that this if test is a null pointer test)?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+    return NewAddr;<br>
<br>
   return Addr;<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>