<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 12:01 PM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 01/25/2016 08:52 PM, David Blaikie wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
<br>
On Sun, Jan 24, 2016 at 6:17 AM, Tobias Grosser via llvm-commits<br></span><span class="">
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>> wrote:<br>
<br>
Author: grosser<br>
Date: Sun Jan 24 08:16:59 2016<br>
New Revision: 258660<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258660&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258660&view=rev</a><br>
Log:<br>
BlockGenerators: Avoid redundant map lookup [NFC]<br>
<br>
Modified:<br>
polly/trunk/lib/CodeGen/BlockGenerators.cpp<br>
<br>
Modified: polly/trunk/lib/CodeGen/BlockGenerators.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=258660&r1=258659&r2=258660&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=258660&r1=258659&r2=258660&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/lib/CodeGen/BlockGenerators.cpp (original)<br>
+++ polly/trunk/lib/CodeGen/BlockGenerators.cpp Sun Jan 24 08:16:59 2016<br>
@@ -338,8 +338,8 @@ Value *BlockGenerator::getOrCreateAlloca<br>
<br>
auto Addr = Map[ScalarBase];<br>
<br>
- if (GlobalMap.count(Addr))<br>
- return GlobalMap[Addr];<br>
+ if (auto NewAddr = GlobalMap.lookup(Addr))<br>
<br>
<br>
Probably best to include the '*' in auto here (if I'm understanding the<br>
code correctly, auto is binding to Instruction* here) to make it clear<br>
that it's a pointer (& that this if test is a null pointer test)?<br>
</span></blockquote>
<br>
Thanks David, this is an AssertingVH, not a plain pointer.</blockquote><div><br></div><div>Ah, right, I see now.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hence, it is<br>
is not possible to write it this way. However, the conversion to null still seems to work as expected. I have no idea how to write it better.<br>
Any suggestions?<br></blockquote><div><br></div><div>Nothing great that comes to mind - could write out the type rather than auto, but I doubt that'd add much. No worries<br><br>- Dave</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Best,<br>
Tobias<br>
</blockquote></div><br></div></div>