<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Rui<br class=""><div><blockquote type="cite" class=""><div class="">On Jan 22, 2016, at 1:06 PM, Rui Ueyama <<a href="mailto:ruiu@google.com" class="">ruiu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Hi Pete,</div><div class=""><br class=""></div><div class="">Looks like both ld and gold don't think that @ is a valid character in a token, so I think we shouldn't, too.</div></div></div></blockquote>Ah, thanks for testing that.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><pre style="" class="">$ ld -script <(echo 'SEARCH_DIR( /Volumes/Data/apple-lld-stage1@2/ )')
ld:/dev/fd/63:1: ignoring invalid character `@' in expression
ld:/dev/fd/63:1: syntax error</pre><pre class=""><font face="arial, sans-serif" class=""><span style="white-space:normal" class="">Do you think you can fix the tests by using relative path instead of absolute path?</span></font></pre></div></div></div></blockquote>Yep, i’ll try do that now and send out a patch.</div><div><br class=""></div><div>Thanks,</div><div>Pete<br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Jan 22, 2016 at 12:48 PM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Rui, Rafael<br class="">
<br class="">
I have a jenkins bot building lld. Due to a plugin called ‘shared workspaces’ its common to have @’s in paths.<br class="">
<br class="">
This bot is then failing on 3 ELF tests (ELF/as-needed.s, ELF/linkerscript.s, ELF/linkerscript2.s)<br class="">
<br class="">
I’ve diagnosed the issue on linkerscript.s and its down to @ not being in the set of unquoted tokens in LinkerScript::tokenize.<br class="">
<br class="">
I’d like to propose a patch, but first I’d like to double check what the preferred solution is. I think its either:<br class="">
- Add @ to the allowable characters in a token, or<br class="">
- Change the test to quote the path<br class="">
<br class="">
Which would you prefer?<br class="">
<br class="">
Thanks,<br class="">
Pete<br class="">
<br class="">
PS, the linkerscipt.s script contains this entry which is the cause of the failure: "SEARCH_DIR( /Volumes/Data/apple-lld-stage1@2/build/tools/lld/test/ELF/Output/linkerscript2.s.tmp.dir )"</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>