<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 21, 2016 at 5:10 PM, Eduard Burtescu via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">eddyb added inline comments.<br>
<br>
================<br>
<span class="">Comment at: lib/Analysis/ConstantFolding.cpp:488<br>
@@ -485,3 +487,3 @@<br>
     return nullptr;<br>
-  Type *DestTy = DestPtrTy->getElementType();<br>
+  Type *SrcTy = SrcPtrTy->getPointerElementType();<br>
<br>
----------------<br>
</span><span class="">dblaikie wrote:<br>
> Presumably this could be getElementType (since SrcPtrTy is already a PointerType) - but in either case this is a stop-gap and will eventually be removed/migrated?<br>
</span>I've been using `getPointerElementType` everywhere so it matches my local setup where `PointerType::getPointerElementType` is the only method used everywhere (the one on `Value` is gone and `PointerType::getElementType` is deprecated).<br></blockquote><div><br></div><div>What's the purpose/advantage of that? (either way, both calls will have to be eliminated - I guess it's easier to grep for "getPointerElementType"?)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="http://reviews.llvm.org/D16418" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16418</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>