<div dir="ltr">Yeah that's what it means. It was already true for all code in llvm and clang and I didn't realize lldb was using it until the bots failed. At which point i fixed one place in lldb. Why didn't the bots flag this one too?</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 13, 2016 at 2:06 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I believe this is causing warnings when building LLDB:<br>
<br>
In file included from<br>
/work/llvm-3.8/llvm.src/tools/lldb/source/Target/ThreadPlanCallFunctionUsingABI.cpp:14:<br>
In file included from<br>
/work/llvm-3.8/llvm.src/tools/lldb/include/lldb/Target/ThreadPlanCallFunctionUsingABI.h:23:<br>
/work/llvm-3.8/llvm.src/include/llvm/IR/Type.h:350:16: error: inline<br>
function 'llvm::Type::getSequentialElementType' is not defined<br>
[-Werror,-Wundefined-inline]<br>
  inline Type *getSequentialElementType() const;<br>
               ^<br>
/work/llvm-3.8/llvm.src/include/llvm/IR/Type.h:353:46: note: used here<br>
<span class="">  Type *getArrayElementType() const { return getSequentialElementType(); }<br>
</span>                                             ^<br>
1 error generated.<br>
<br>
Does your change mean that everyone including Types.h also needs to<br>
include DerivedTypes.h, to get the definitions of those inline<br>
functions?<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Dec 24, 2015 at 8:06 PM, Craig Topper via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: ctopper<br>
> Date: Thu Dec 24 22:06:20 2015<br>
> New Revision: 256406<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=256406&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=256406&view=rev</a><br>
> Log:<br>
> [IR] Mark the Type subclass helper methods 'inline' and move their definitions to DerivedTypes.h so they can be inlined by the compiler.<br>
><br>
> Modified:<br>
>     llvm/trunk/include/llvm/IR/DerivedTypes.h<br>
>     llvm/trunk/include/llvm/IR/Type.h<br>
>     llvm/trunk/lib/IR/Type.cpp<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">~Craig</div>
</div>