<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 24, 2015 at 2:14 AM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Thu Dec 24 04:14:05 2015<br>
New Revision: 256379<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=256379&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=256379&view=rev</a><br>
Log:<br>
Remove `continue` to make the code a bit shorter. NFC.<br>
<br>
Modified:<br>
    lld/trunk/ELF/MarkLive.cpp<br>
<br>
Modified: lld/trunk/ELF/MarkLive.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/MarkLive.cpp?rev=256379&r1=256378&r2=256379&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/MarkLive.cpp?rev=256379&r1=256378&r2=256379&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/MarkLive.cpp (original)<br>
+++ lld/trunk/ELF/MarkLive.cpp Thu Dec 24 04:14:05 2015<br>
@@ -114,14 +114,11 @@ template <class ELFT> void lld::elf2::ma<br>
   }<br>
<br>
   // Preserve special sections.<br>
-  for (const std::unique_ptr<ObjectFile<ELFT>> &F : Symtab->getObjectFiles()) {<br>
-    for (InputSectionBase<ELFT> *Sec : F->getSections()) {<br>
-      if (!Sec || Sec == &InputSection<ELFT>::Discarded)<br>
-        continue;<br>
-      if (isReserved(Sec))<br>
-        Enqueue(Sec);<br>
-    }<br>
-  }<br>
+  for (const std::unique_ptr<ObjectFile<ELFT>> &F : Symtab->getObjectFiles())<br>
+    for (InputSectionBase<ELFT> *Sec : F->getSections())<br>
+      if (Sec && Sec != &InputSection<ELFT>::Discarded)<br>
+        if (isReserved(Sec))<br></blockquote><div><br></div><div>Any reason not to roll all 3 conditions into one if? Seems a bit arbitrary to searate the isReserved condition from the other two.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+          Enqueue(Sec);<br>
<br>
   // Mark all reachable sections.<br>
   while (!Q.empty())<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>