<div dir="ltr">Hi Dan,<div><br></div><div>I don't know if I'm the only one getting this, but it seems like your patch causes timeouts for me and for some bots I'm testing with (they're all timing out after your commit).</div><div><br></div><div>I used the following to repro locally:</div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><font face="monospace, monospace" size="1">cmake ../llvm -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DLLVM_BUILD_TESTS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_TARGETS_TO_BUILD="X86" && make check-all -j$(nproc)</font></blockquote><div>Things are stuck at "running all regression tests".</div><div><br></div><div>I have the python processes at the bottom of this email hung (all disappear when I kill make). I'm pretty suspicious of the infinite_loop.py test considering things seem to loop forever :-)</div><div><br></div><div>The LLVM waterfall at <a href="http://lab.llvm.org:8011/console">http://lab.llvm.org:8011/console</a> seems fine, so maybe it's a Python version difference? The bots I'm using are pretty simple x86 machines, whereas my machine is a beefy one, so I don't think it's a problem with too-slow or too-big machine.</div><div><br></div><div>Would you have an idea of what's going on? I haven't dug into the code yet since I figure you may already have a hunch.</div><div><br></div><div>Hung processes:</div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div><font face="monospace, monospace" size="1">/bin/sh -c cd /s/llvm/out && /usr/bin/python /s/llvm/llvm/utils/lit/lit.py -sv --param clang_site_config=/s/llvm/out/tools/clang/test/lit.site.cfg --param llvm_site_config=/s/llvm/out/test/lit.site.cfg --param llvm_unit_site_config=/s/llvm/out/test/Unit/lit.site.cfg /s/llvm/out/tools/clang/test /s/llvm/out/utils/lit /s/llvm/out/test</font></div><div><font face="monospace, monospace" size="1">/usr/bin/python /s/llvm/llvm/utils/lit/lit.py -sv --param clang_site_config=/s/llvm/out/tools/clang/test/lit.site.cfg --param llvm_site_config=/s/llvm/out/test/lit.site.cfg --param llvm_unit_site_config=/s/llvm/out/test/Unit/lit.site.cfg /s/llvm/out/tools/clang/test /s/llvm/out/utils/lit /s/llvm/out/test</font></div><div><font face="monospace, monospace" size="1">/usr/bin/python /s/llvm/llvm/utils/lit/lit.py -sv --param clang_site_config=/s/llvm/out/tools/clang/test/lit.site.cfg --param llvm_site_config=/s/llvm/out/test/lit.site.cfg --param llvm_unit_site_config=/s/llvm/out/test/Unit/lit.site.cfg /s/llvm/out/tools/clang/test /s/llvm/out/utils/lit /s/llvm/out/test</font></div><div><font face="monospace, monospace" size="1">/usr/bin/python /s/llvm/llvm/utils/lit/lit.py -sv --param clang_site_config=/s/llvm/out/tools/clang/test/lit.site.cfg --param llvm_site_config=/s/llvm/out/test/lit.site.cfg --param llvm_unit_site_config=/s/llvm/out/test/Unit/lit.site.cfg /s/llvm/out/tools/clang/test /s/llvm/out/utils/lit /s/llvm/out/test</font></div><div><font face="monospace, monospace" size="1">not /usr/bin/python /s/llvm/llvm/utils/lit/lit.py -j 1 -v /s/llvm/out/utils/lit/tests/../tests/Inputs/googletest-timeout --timeout=1</font></div><div><font face="monospace, monospace" size="1">/usr/bin/python /s/llvm/llvm/utils/lit/lit.py -j 1 -v /s/llvm/out/utils/lit/tests/../tests/Inputs/googletest-timeout --timeout=1</font></div><div><font face="monospace, monospace" size="1">not /usr/bin/python /s/llvm/llvm/utils/lit/lit.py /s/llvm/out/utils/lit/tests/../tests/Inputs/shtest-timeout/<span style="background-color:rgb(255,255,0)">infinite_loop.py </span>/s/llvm/out/utils/lit/tests/../tests/Inputs/shtest-timeout/quick_then_slow.py /s/llvm/out/utils/lit/tests/../tests/Inputs/shtest-timeout/short.py /s/llvm/out/utils/lit/tests/../tests/Inputs/shtest-timeout/slow.py -j 1 -v --debug --timeout 1 --param external=1</font></div><div><font face="monospace, monospace" size="1">/usr/bin/python /s/llvm/llvm/utils/lit/lit.py /s/llvm/out/utils/lit/tests/../tests/Inputs/shtest-timeout/<span style="background-color:rgb(255,255,0)">infinite_loop.py </span>/s/llvm/out/utils/lit/tests/../tests/Inputs/shtest-timeout/quick_then_slow.py /s/llvm/out/utils/lit/tests/../tests/Inputs/shtest-timeout/short.py /s/llvm/out/utils/lit/tests/../tests/Inputs/shtest-timeout/slow.py -j 1 -v --debug --timeout 1 --param external=1</font></div><div><font face="monospace, monospace" size="1">/usr/bin/python /media/jfb/ssd/llvm/out/utils/lit/tests/Inputs/shtest-timeout/infinite_loop.py</font></div><div><font face="monospace, monospace" size="1">python /media/jfb/ssd/llvm/out/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest --gtest_filter=FirstTest.subTestC</font></div></blockquote></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 8, 2016 at 2:41 PM, Dan Liew via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> Either way, this patch is an improvement over what we have, so let’s go with it.<br>
<br>
</span>Committed in r257221.<br>
<br>
I'll try to keep an eye out for any build bot failures caused by this change.<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>