<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 17, 2015 at 6:30 PM, Vedant Kumar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vedantk<br>
Date: Thu Dec 17 20:30:45 2015<br>
New Revision: 255978<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=255978&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=255978&view=rev</a><br>
Log:<br>
Revert "[Option] Introduce Arg::print(raw_ostream&) and use llvm::dbgs"<br>
<br>
This reverts commit r255977. This is part of<br>
<a href="http://reviews.llvm.org/D15634" rel="noreferrer" target="_blank">http://reviews.llvm.org/D15634</a>.<br></blockquote><div><br></div><div>It's helpful to mention why something is reverted in the commit message (include a link to a buildbot, etc as well) - so someone can see why & avoid making the same mistake, potentially.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/include/llvm/Option/Arg.h<br>
    llvm/trunk/lib/Option/Arg.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/Option/Arg.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Option/Arg.h?rev=255978&r1=255977&r2=255978&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Option/Arg.h?rev=255978&r1=255977&r2=255978&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Option/Arg.h (original)<br>
+++ llvm/trunk/include/llvm/Option/Arg.h Thu Dec 17 20:30:45 2015<br>
@@ -18,7 +18,6 @@<br>
 #include "llvm/ADT/SmallVector.h"<br>
 #include "llvm/ADT/StringRef.h"<br>
 #include "llvm/Option/Option.h"<br>
-#include "llvm/Support/raw_ostream.h"<br>
 #include <string><br>
<br>
 namespace llvm {<br>
@@ -114,8 +113,6 @@ public:<br>
   /// when rendered as a input (e.g., Xlinker).<br>
   void renderAsInput(const ArgList &Args, ArgStringList &Output) const;<br>
<br>
-  void print(raw_ostream &OS) const;<br>
-<br>
   void dump() const;<br>
<br>
   /// \brief Return a formatted version of the argument and<br>
<br>
Modified: llvm/trunk/lib/Option/Arg.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Option/Arg.cpp?rev=255978&r1=255977&r2=255978&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Option/Arg.cpp?rev=255978&r1=255977&r2=255978&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Option/Arg.cpp (original)<br>
+++ llvm/trunk/lib/Option/Arg.cpp Thu Dec 17 20:30:45 2015<br>
@@ -12,7 +12,7 @@<br>
 #include "llvm/ADT/Twine.h"<br>
 #include "llvm/Option/ArgList.h"<br>
 #include "llvm/Option/Option.h"<br>
-#include "llvm/Support/Debug.h"<br>
+#include "llvm/Support/raw_ostream.h"<br>
<br>
 using namespace llvm;<br>
 using namespace llvm::opt;<br>
@@ -43,24 +43,21 @@ Arg::~Arg() {<br>
   }<br>
 }<br>
<br>
-void Arg::print(raw_ostream &OS) const {<br>
-  OS << "<";<br>
+void Arg::dump() const {<br>
+  llvm::errs() << "<";<br>
<br>
-  OS << " Opt:";<br>
+  llvm::errs() << " Opt:";<br>
   Opt.dump();<br>
<br>
-  OS << " Index:" << Index;<br>
+  llvm::errs() << " Index:" << Index;<br>
<br>
-  OS << " Values: [";<br>
+  llvm::errs() << " Values: [";<br>
   for (unsigned i = 0, e = Values.size(); i != e; ++i) {<br>
-    OS << "'" << Values[i] << "'";<br>
-    if (i != e - 1) llvm::errs() << ", ";<br>
+    if (i) llvm::errs() << ", ";<br>
+    llvm::errs() << "'" << Values[i] << "'";<br>
   }<br>
-  OS << "]>\n";<br>
-}<br>
<br>
-void Arg::dump() const {<br>
-  print(llvm::dbgs());<br>
+  llvm::errs() << "]>\n";<br>
 }<br>
<br>
 std::string Arg::getAsString(const ArgList &Args) const {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>