<div dir="ltr">Can you explain a little bit more?<div><br></div><div>IE what the issue was before you think no longer exists anymore?<br><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 7, 2016 at 11:21 AM, Michael Liao via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hliao<br>
Date: Thu Jan  7 13:21:29 2016<br>
New Revision: 257086<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=257086&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=257086&view=rev</a><br>
Log:<br>
[DominatorTree] Remove unnecessary map population. NFC.<br>
<br>
- The reason of population these maps seems not valid any more.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Support/GenericDomTree.h<br>
<br>
Modified: llvm/trunk/include/llvm/Support/GenericDomTree.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/GenericDomTree.h?rev=257086&r1=257085&r2=257086&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/GenericDomTree.h?rev=257086&r1=257085&r2=257086&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Support/GenericDomTree.h (original)<br>
+++ llvm/trunk/include/llvm/Support/GenericDomTree.h Thu Jan  7 13:21:29 2016<br>
@@ -724,25 +724,17 @@ public:<br>
     if (!this->IsPostDominators) {<br>
       // Initialize root<br>
       NodeT *entry = TraitsTy::getEntryNode(&F);<br>
-      this->Roots.push_back(entry);<br>
-      this->IDoms[entry] = nullptr;<br>
-      this->DomTreeNodes[entry] = nullptr;<br>
+      addRoot(entry);<br>
<br>
       Calculate<FT, NodeT *>(*this, F);<br>
     } else {<br>
       // Initialize the roots list<br>
       for (typename TraitsTy::nodes_iterator I = TraitsTy::nodes_begin(&F),<br>
                                              E = TraitsTy::nodes_end(&F);<br>
-           I != E; ++I) {<br>
+           I != E; ++I)<br>
         if (TraitsTy::child_begin(&*I) == TraitsTy::child_end(&*I))<br>
           addRoot(&*I);<br>
<br>
-        // Prepopulate maps so that we don't get iterator invalidation issues<br>
-        // later.<br>
-        this->IDoms[&*I] = nullptr;<br>
-        this->DomTreeNodes[&*I] = nullptr;<br>
-      }<br>
-<br>
       Calculate<FT, Inverse<NodeT *>>(*this, F);<br>
     }<br>
   }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>