<div dir="ltr">And feel free to roll it back without code review if you find a regression.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 7, 2016 at 10:33 AM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This is indeed a culprit. Can you revert this locally and try it again to verify?</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 7, 2016 at 10:31 AM, Davide Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On Thu, Jan 7, 2016 at 10:17 AM, Rui Ueyama via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: ruiu<br>
> Date: Thu Jan  7 12:17:29 2016<br>
> New Revision: 257080<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=257080&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=257080&view=rev</a><br>
> Log:<br>
> Remove unnecessary type casts.<br>
><br>
> Modified:<br>
>     lld/trunk/ELF/OutputSections.cpp<br>
><br>
> Modified: lld/trunk/ELF/OutputSections.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.cpp?rev=257080&r1=257079&r2=257080&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.cpp?rev=257080&r1=257079&r2=257080&view=diff</a><br>
> ==============================================================================<br>
> --- lld/trunk/ELF/OutputSections.cpp (original)<br>
> +++ lld/trunk/ELF/OutputSections.cpp Thu Jan  7 12:17:29 2016<br>
> @@ -1161,8 +1161,7 @@ template <class ELFT> void MergeOutputSe<br>
><br>
>  template <class ELFT><br>
>  StringTableSection<ELFT>::StringTableSection(StringRef Name, bool Dynamic)<br>
> -    : OutputSectionBase<ELFT>(Name, SHT_STRTAB,<br>
> -                              Dynamic ? (uintX_t)SHF_ALLOC : 0),<br>
> +    : OutputSectionBase<ELFT>(Name, SHT_STRTAB, Dynamic ? SHF_ALLOC : 0),<br>
>        Dynamic(Dynamic) {<br>
>    this->Header.sh_addralign = 1;<br>
>  }<br>
> @@ -1235,7 +1234,7 @@ SymbolTableSection<ELFT>::SymbolTableSec<br>
>      SymbolTable<ELFT> &Table, StringTableSection<ELFT> &StrTabSec)<br>
>      : OutputSectionBase<ELFT>(StrTabSec.isDynamic() ? ".dynsym" : ".symtab",<br>
>                                StrTabSec.isDynamic() ? SHT_DYNSYM : SHT_SYMTAB,<br>
> -                              StrTabSec.isDynamic() ? (uintX_t)SHF_ALLOC : 0),<br>
> +                              StrTabSec.isDynamic() ? SHF_ALLOC : 0),<br>
>        Table(Table), StrTabSec(StrTabSec) {<br>
>    typedef OutputSectionBase<ELFT> Base;<br>
>    typename Base::Elf_Shdr &Header = this->Header;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div>hmm, this or another commit between yesterday and today broke gcc-4.8<br>
with -Werror on my PPC box. This seems the obvious culprit, but I<br>
didn't dig into that (yet).<br>
<br>
[13/15] Building CXX object tools/lld/...Files/lldELF2.dir/OutputSections.cpp.o<br>
../tools/lld/ELF/OutputSections.cpp: In constructor<br>
'lld::elf2::StringTableSection<ELFT>::StringTableSection(llvm::StringRef,<br>
bool)':<br>
../tools/lld/ELF/OutputSections.cpp:1164:71: warning: enumeral and<br>
non-enumeral type in conditional expression [enabled by default]<br>
<span>     : OutputSectionBase<ELFT>(Name, SHT_STRTAB, Dynamic ? SHF_ALLOC : 0),<br>
</span>                                                                       ^<br>
../tools/lld/ELF/OutputSections.cpp: In instantiation of<br>
'lld::elf2::StringTableSection<ELFT>::StringTableSection(llvm::StringRef,<br>
bool) [with ELFT = llvm::object::ELFType<<br>
(llvm::support::endianness)1u, false>]':<br>
../tools/lld/ELF/OutputSections.cpp:1517:16:   required from here<br>
../tools/lld/ELF/OutputSections.cpp:1165:22: warning: enumeral and<br>
non-enumeral type in conditional expression [enabled by default]<br>
       Dynamic(Dynamic) {<br>
                      ^<br>
../tools/lld/ELF/OutputSections.cpp: In instantiation of<br>
'lld::elf2::StringTableSection<ELFT>::StringTableSection(llvm::StringRef,<br>
bool) [with ELFT = llvm::object::ELFType<<br>
(llvm::support::endianness)0u, false>]':<br>
../tools/lld/ELF/OutputSections.cpp:1518:16:   required from here<br>
../tools/lld/ELF/OutputSections.cpp:1165:22: warning: enumeral and<br>
non-enumeral type in conditional expression [enabled by default]<br>
../tools/lld/ELF/OutputSections.cpp: In instantiation of<br>
'lld::elf2::StringTableSection<ELFT>::StringTableSection(llvm::StringRef,<br>
bool) [with ELFT = llvm::object::ELFType<<br>
(llvm::support::endianness)1u, true>]':<br>
../tools/lld/ELF/OutputSections.cpp:1519:16:   required from here<br>
../tools/lld/ELF/OutputSections.cpp:1165:22: warning: enumeral and<br>
non-enumeral type in conditional expression [enabled by default]<br>
../tools/lld/ELF/OutputSections.cpp: In instantiation of<br>
'lld::elf2::StringTableSection<ELFT>::StringTableSection(llvm::StringRef,<br>
bool) [with ELFT = llvm::object::ELFType<<br>
(llvm::support::endianness)0u, true>]':<br>
../tools/lld/ELF/OutputSections.cpp:1520:16:   required from here<br>
../tools/lld/ELF/OutputSections.cpp:1165:22: warning: enumeral and<br>
non-enumeral type in conditional expression [enabled by default]<br>
../tools/lld/ELF/OutputSections.cpp: In instantiation of<br>
'lld::elf2::SymbolTableSection<ELFT>::SymbolTableSection(lld::elf2::SymbolTable<ELFT>&,<br>
lld::elf2::StringTableSecti<br>
on<ELFT>&) [with ELFT =<br>
llvm::object::ELFType<(llvm::support::endianness)1u, false>]':<br>
../tools/lld/ELF/OutputSections.cpp:1522:16:   required from here<br>
../tools/lld/ELF/OutputSections.cpp:1237:53: warning: enumeral and<br>
non-enumeral type in conditional expression [enabled by default]<br>
                               StrTabSec.isDynamic() ? SHF_ALLOC : 0),<br>
<br>
Can you please take a look?<br>
<br>
Thanks!<br>
<span><font color="#888888"><br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div>