<div dir="ltr">Cool! <div>I wonder if it makes sense to have a fuzzer for lld, similar to what we have for clang and clang-format? </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 22, 2015 at 5:06 PM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Tue Dec 22 19:06:39 2015<br>
New Revision: 256309<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=256309&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=256309&view=rev</a><br>
Log:<br>
Fix two asan found bugs:<br>
<br>
We were leaking InputFile subclasses data.<br>
UndefinedElf was missing a classof.<br>
<br>
Modified:<br>
    lld/trunk/ELF/InputFiles.cpp<br>
    lld/trunk/ELF/InputFiles.h<br>
    lld/trunk/ELF/Symbols.h<br>
<br>
Modified: lld/trunk/ELF/InputFiles.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=256309&r1=256308&r2=256309&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=256309&r1=256308&r2=256309&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputFiles.cpp (original)<br>
+++ lld/trunk/ELF/InputFiles.cpp Tue Dec 22 19:06:39 2015<br>
@@ -31,6 +31,8 @@ public:<br>
 };<br>
 }<br>
<br>
+InputFile::~InputFile() {}<br>
+<br>
 template <class ELFT><br>
 ELFFileBase<ELFT>::ELFFileBase(Kind K, MemoryBufferRef M)<br>
     : InputFile(K, M), ELFObj(MB.getBuffer(), ECRAII().getEC()) {}<br>
<br>
Modified: lld/trunk/ELF/InputFiles.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.h?rev=256309&r1=256308&r2=256309&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.h?rev=256309&r1=256308&r2=256309&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputFiles.h (original)<br>
+++ lld/trunk/ELF/InputFiles.h Tue Dec 22 19:06:39 2015<br>
@@ -35,6 +35,7 @@ class InputFile {<br>
 public:<br>
   enum Kind { ObjectKind, SharedKind, ArchiveKind };<br>
   Kind kind() const { return FileKind; }<br>
+  virtual ~InputFile();<br>
<br>
   StringRef getName() const { return MB.getBufferIdentifier(); }<br>
<br>
<br>
Modified: lld/trunk/ELF/Symbols.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=256309&r1=256308&r2=256309&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=256309&r1=256308&r2=256309&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Symbols.h (original)<br>
+++ lld/trunk/ELF/Symbols.h Tue Dec 22 19:06:39 2015<br>
@@ -270,6 +270,10 @@ template <class ELFT> class UndefinedElf<br>
 public:<br>
   UndefinedElf(StringRef N, const Elf_Sym &Sym);<br>
   const Elf_Sym &Sym;<br>
+<br>
+  static bool classof(const SymbolBody *S) {<br>
+    return S->kind() == SymbolBody::UndefinedElfKind;<br>
+  }<br>
 };<br>
<br>
 template <class ELFT> class SharedSymbol : public Defined<ELFT> {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>