<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">For some reason, I can't seem to log in
      to phabricator at the moment... A couple of comments below.<br>
      <br>
      "InferFunctionAttrs" - bikeshed wise, this seems like a very
      generic, non-discriptive name.  Possibly:
      InferFunctionAttrsFromTLI?  Or something which otherwise gives a
      clue as to what we're infering from?<br>
      <br>
      This really seems like it should somehow be a tablegen file.  I
      know you're just moving code around, but the long list of hand
      written code for each function smells.  Particularly the type
      checking of arguments after TLI already matched to an enum...<br>
      <br>
      Stale comment in "inferAllPrototypeAttributes".<br>
      <br>
      I'm uncomfortable with the addition of the various no-recurse
      attributes.  I'm not saying your choices are wrong, but mixing
      them in with a large code motion patch makes them hard to review. 
      There's also a question of what we're assuming about the runtime
      environment.  After all, there is a perfectly legal (if unlikely)
      recursive implementation of strlen.<br>
      <br>
      Otherwise, LGTM.<br>
      <br>
      Philip  <br>
      <br>
      <br>
      <br>
      On 12/20/2015 03:13 AM, Chandler Carruth via llvm-commits wrote:<br>
    </div>
    <blockquote
      cite="mid:6c91c054a01609ae91b685ea76ca9403@localhost.localdomain"
      type="cite">
      <pre wrap="">chandlerc updated this revision to Diff 43324.
chandlerc added a comment.

Finish wiring up the new pass manager for inferring function attrs, and test it.


<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D15676">http://reviews.llvm.org/D15676</a>

Files:
  include/llvm/InitializePasses.h
  include/llvm/Transforms/IPO/InferFunctionAttrs.h
  lib/Passes/PassBuilder.cpp
  lib/Passes/PassRegistry.def
  lib/Transforms/IPO/CMakeLists.txt
  lib/Transforms/IPO/FunctionAttrs.cpp
  lib/Transforms/IPO/IPO.cpp
  lib/Transforms/IPO/InferFunctionAttrs.cpp
  lib/Transforms/IPO/PassManagerBuilder.cpp
  test/Transforms/FunctionAttrs/2009-01-04-Annotate.ll
  test/Transforms/FunctionAttrs/annotate-1.ll
  test/Transforms/InferFunctionAttrs/annotate.ll
  test/Transforms/InstCombine/strto-1.ll

</pre>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>