<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 18, 2015, at 5:49 , Alexey Denisov <<a href="mailto:1101.debian@gmail.com" class="">1101.debian@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><blockquote type="cite" class="">Ha, I was still thinking something simpler.<br class=""></blockquote><br class="">I came up with the same solution when I woke up next morning :-D<br class=""><br class=""><blockquote type="cite" class="">EXPECT_FALSE(Begin == std::next(Begin));<br class="">EXPECT_FALSE(std::next(Begin) == Begin);<br class=""></blockquote><br class="">I have faced an issue with such tests. std::next in the case of SequenceNode mutates value in-place, so that iterators are equal.<br class="">But it could be tested using some other BaseT, not a SequenceNode. I also realised it afterwards.<br class=""><br class=""><blockquote type="cite" class="">InputIterators don't actually guarantee that this is valid, so we don't have to implement it, but I think we should do it just so other people don't get bitten. There's not much reason not to.<br class=""></blockquote></div></div></blockquote></div><br class=""><div class="">I looked at basic_collection_iterator again. It really shouldn't be defining itself as a forward iterator. I think we should just make it an input iterator and <i class="">assert</i> that the entries are the same if the bases are the same.</div><div class=""><br class=""></div><div class="">Jordan</div></body></html>