<div dir="ltr">The one from the line above is from me. Evgeniy and I both saw the unused variable and fixed them slightly differently at about the same time. Only one cast is needed, so I'll just remove my change.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 15, 2015 at 3:35 PM, Peter Collingbourne via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Dec 15, 2015 at 11:30:29PM -0000, Evgeniy Stepanov via llvm-commits wrote:<br>
> Author: eugenis<br>
> Date: Tue Dec 15 17:30:29 2015<br>
> New Revision: 255706<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=255706&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=255706&view=rev</a><br>
> Log:<br>
> Suppress unused variable warning in the no-asserts build.<br>
><br>
> Modified:<br>
> llvm/trunk/lib/Transforms/IPO/CrossDSOCFI.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/IPO/CrossDSOCFI.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/CrossDSOCFI.cpp?rev=255706&r1=255705&r2=255706&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/CrossDSOCFI.cpp?rev=255706&r1=255705&r2=255706&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Transforms/IPO/CrossDSOCFI.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/IPO/CrossDSOCFI.cpp Tue Dec 15 17:30:29 2015<br>
> @@ -92,6 +92,7 @@ ConstantInt *CrossDSOCFI::extractBitSetT<br>
> (void)F;<br>
> // But can never be a function declaration.<br>
> assert(!F || !F->isDeclaration());<br>
> + (void)F; // Suppress unused variable warning in the no-asserts build.<br>
<br>
</span>You already have this line above?<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Peter<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>