<div dir="ltr">Nice!</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 8:14 AM, George Rimar <span dir="ltr"><<a href="mailto:grimar@accesssoftek.com" target="_blank">grimar@accesssoftek.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">grimar created this revision.<br>
grimar added reviewers: ruiu, rafael.<br>
grimar added subscribers: llvm-commits, grimar.<br>
<br>
Just a little reformat of conditions.<br>
<br>
<a href="http://reviews.llvm.org/D15453" rel="noreferrer" target="_blank">http://reviews.llvm.org/D15453</a><br>
<br>
Files:<br>
  ELF/OutputSections.cpp<br>
<br>
Index: ELF/OutputSections.cpp<br>
===================================================================<br>
--- ELF/OutputSections.cpp<br>
+++ ELF/OutputSections.cpp<br>
@@ -264,21 +264,19 @@<br>
     bool LazyReloc = Body && Target->supportsLazyRelocations() &&<br>
                      Target->relocNeedsPlt(Type, *Body);<br>
<br>
-    if (CanBePreempted) {<br>
-      unsigned GotReloc =<br>
-          Body->isTLS() ? Target->getTlsGotReloc() : Target->getGotReloc();<br>
-      if (NeedsGot)<br>
-        P->setSymbolAndType(Body->getDynamicSymbolTableIndex(),<br>
-                            LazyReloc ? Target->getPltReloc() : GotReloc,<br>
-                            Config->Mips64EL);<br>
-      else<br>
-        P->setSymbolAndType(Body->getDynamicSymbolTableIndex(),<br>
-                            NeedsCopy ? Target->getCopyReloc()<br>
-                                      : Target->getDynReloc(Type),<br>
-                            Config->Mips64EL);<br>
-    } else {<br>
-      P->setSymbolAndType(0, Target->getRelativeReloc(), Config->Mips64EL);<br>
-    }<br>
+    unsigned Sym = CanBePreempted ? Body->getDynamicSymbolTableIndex() : 0;<br>
+    unsigned Rel;<br>
+    if (!CanBePreempted)<br>
+      Rel = Target->getRelativeReloc();<br>
+    else if (LazyReloc)<br>
+      Rel = Target->getPltReloc();<br>
+    else if (NeedsGot)<br>
+      Rel = Body->isTLS() ? Target->getTlsGotReloc() : Target->getGotReloc();<br>
+    else if (NeedsCopy)<br>
+      Rel = Target->getCopyReloc();<br>
+    else<br>
+      Rel = Target->getDynReloc(Type);<br>
+    P->setSymbolAndType(Sym, Rel, Config->Mips64EL);<br>
<br>
     if (NeedsGot) {<br>
       if (LazyReloc)<br>
<br>
<br>
</blockquote></div><br></div>