<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 3, 2015 at 12:20 AM, Andy Gibbs via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: andyg<br>
Date: Thu Dec  3 02:20:20 2015<br>
New Revision: 254592<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254592&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254592&view=rev</a><br>
Log:<br>
Fix class SCEVPredicate has virtual functions and accessible non-virtual destructor.<br></blockquote><div><br>Wait - why did the dtor need to be made virtual at all? These objects are never destroyed polymorphically, so far as I can tell.<br><br>Could we just disable the GCC warning that was firing here instead? (if I understand correctly and this was a GCC warning)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
It is not enough to simply make the destructor virtual since there is a g++ 4.7<br>
issue (see <a href="https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53613" rel="noreferrer" target="_blank">https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53613</a>) that throws the<br>
error "looser throw specifier for ... overridding ~SCEVPredicate() noexcept".<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Analysis/ScalarEvolution.h<br>
    llvm/trunk/lib/Analysis/ScalarEvolution.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/Analysis/ScalarEvolution.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/ScalarEvolution.h?rev=254592&r1=254591&r2=254592&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/ScalarEvolution.h?rev=254592&r1=254591&r2=254592&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Analysis/ScalarEvolution.h (original)<br>
+++ llvm/trunk/include/llvm/Analysis/ScalarEvolution.h Thu Dec  3 02:20:20 2015<br>
@@ -183,7 +183,7 @@ namespace llvm {<br>
<br>
   protected:<br>
     SCEVPredicateKind Kind;<br>
-    ~SCEVPredicate() = default;<br>
+    virtual ~SCEVPredicate();<br>
     SCEVPredicate(const SCEVPredicate&) = default;<br>
     SCEVPredicate &operator=(const SCEVPredicate&) = default;<br>
<br>
<br>
Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=254592&r1=254591&r2=254592&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=254592&r1=254591&r2=254592&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original)<br>
+++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Thu Dec  3 02:20:20 2015<br>
@@ -9643,6 +9643,8 @@ SCEVPredicate::SCEVPredicate(const Foldi<br>
                              SCEVPredicateKind Kind)<br>
     : FastID(ID), Kind(Kind) {}<br>
<br>
+SCEVPredicate::~SCEVPredicate() {}<br>
+<br>
 SCEVEqualPredicate::SCEVEqualPredicate(const FoldingSetNodeIDRef ID,<br>
                                        const SCEVUnknown *LHS,<br>
                                        const SCEVConstant *RHS)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>