Hi David,<br><br>Sure, will do. This change has no measurable time impact on a bootstrap build of clang. <br><br>James<br><div class="gmail_quote"><div dir="ltr">On Wed, 2 Dec 2015 at 16:05, David Majnemer via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">majnemer added a comment.<br>
<br>
Do you have data on how this change impacts compile time?<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:20<br>
@@ -19,2 +19,3 @@<br>
 #include "llvm/Transforms/Utils/CmpInstAnalysis.h"<br>
+#include "llvm/ADT/StringExtras.h"<br>
 using namespace llvm;<br>
----------------<br>
Please sort this include.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D15118" rel="noreferrer" target="_blank">http://reviews.llvm.org/D15118</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>