<div dir="ltr">Great idea! I've wanted this for a long time!</div><br><div class="gmail_quote"><div dir="ltr">On Tue, 1 Dec 2015 at 07:52 Sanjoy Das via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sanjoy<br>
Date: Tue Dec  1 01:49:27 2015<br>
New Revision: 254391<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254391&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254391&view=rev</a><br>
Log:<br>
Introduce a range version of std::find, and use in SCEV<br>
<br>
Reviewers: dblaikie, pcc<br>
<br>
Subscribers: llvm-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D15064" rel="noreferrer" target="_blank">http://reviews.llvm.org/D15064</a><br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/STLExtras.h<br>
    llvm/trunk/lib/Analysis/ScalarEvolution.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/STLExtras.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/STLExtras.h?rev=254391&r1=254390&r2=254391&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/STLExtras.h?rev=254391&r1=254390&r2=254391&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/STLExtras.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/STLExtras.h Tue Dec  1 01:49:27 2015<br>
@@ -379,6 +379,13 @@ bool any_of(R &&Range, UnaryPredicate &&<br>
                      std::forward<UnaryPredicate>(P));<br>
 }<br>
<br>
+/// Provide wrappers to std::find which take ranges instead of having to pass<br>
+/// begin/end explicitly.<br>
+template<typename R, class T><br>
+auto find(R &&Range, const T &val) -> decltype(Range.begin()) {<br>
+  return std::find(Range.begin(), Range.end(), val);<br>
+}<br>
+<br>
 //===----------------------------------------------------------------------===//<br>
 //     Extra additions to <memory><br>
 //===----------------------------------------------------------------------===//<br>
<br>
Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=254391&r1=254390&r2=254391&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=254391&r1=254390&r2=254391&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original)<br>
+++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Tue Dec  1 01:49:27 2015<br>
@@ -7964,8 +7964,7 @@ static bool IsMaxConsistingOf(const SCEV<br>
   const MaxExprType *MaxExpr = dyn_cast<MaxExprType>(MaybeMaxExpr);<br>
   if (!MaxExpr) return false;<br>
<br>
-  auto It = std::find(MaxExpr->op_begin(), MaxExpr->op_end(), Candidate);<br>
-  return It != MaxExpr->op_end();<br>
+  return find(MaxExpr->operands(), Candidate) != MaxExpr->op_end();<br>
 }<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>