<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 30, 2015 at 10:13 PM, Craig Topper via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Tue Dec  1 00:13:13 2015<br>
New Revision: 254386<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254386&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254386&view=rev</a><br>
Log:<br>
[X86] Use array_lengthof instead of calculating manually. Also change index types to size_t to match.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86InstrInfo.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86InstrInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrInfo.cpp?rev=254386&r1=254385&r2=254386&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrInfo.cpp?rev=254386&r1=254385&r2=254386&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86InstrInfo.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86InstrInfo.cpp Tue Dec  1 00:13:13 2015<br>
@@ -3517,23 +3517,23 @@ unsigned X86InstrInfo::getFMA3OpcodeToCo<br>
   bool IsIntrinOpcode;<br>
   isFMA3(Opc, &IsIntrinOpcode);<br>
<br>
-  unsigned GroupsNum;<br>
+  size_t GroupsNum;<br>
   const unsigned (*OpcodeGroups)[3];<br></blockquote><div><br></div><div>Worth replacing these two variables ^ with one ArrayRef<unsigned[3]> ?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   if (IsIntrinOpcode) {<br>
-    GroupsNum = sizeof(IntrinOpcodeGroups) / sizeof(IntrinOpcodeGroups[0]);<br>
+    GroupsNum = array_lengthof(IntrinOpcodeGroups);<br>
     OpcodeGroups = IntrinOpcodeGroups;<br>
   } else {<br>
-    GroupsNum = sizeof(RegularOpcodeGroups) / sizeof(RegularOpcodeGroups[0]);<br>
+    GroupsNum = array_lengthof(RegularOpcodeGroups);<br>
     OpcodeGroups = RegularOpcodeGroups;<br>
   }<br>
<br>
   const unsigned *FoundOpcodesGroup = nullptr;<br>
-  unsigned FormIndex;<br>
+  size_t FormIndex;<br>
<br>
   // Look for the input opcode in the corresponding opcodes table.<br>
-  unsigned GroupIndex = 0;<br>
-  for (; GroupIndex < GroupsNum && !FoundOpcodesGroup; GroupIndex++) {<br>
-    for (FormIndex = 0; FormIndex < FormsNum; FormIndex++) {<br>
+  for (size_t GroupIndex = 0; GroupIndex < GroupsNum && !FoundOpcodesGroup;<br>
+         ++GroupIndex) {<br>
+    for (FormIndex = 0; FormIndex < FormsNum; ++FormIndex) {<br>
       if (OpcodeGroups[GroupIndex][FormIndex] == Opc) {<br>
         FoundOpcodesGroup = OpcodeGroups[GroupIndex];<br>
         break;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>