<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 30, 2015 at 9:42 AM, Chris Bieneman via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: cbieneman<br>
Date: Mon Nov 30 11:42:30 2015<br>
New Revision: 254308<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254308&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254308&view=rev</a><br>
Log:<br>
[CMake] Add -fvisibility-inlines-hidden if the compiler supports it.<br>
<br>
This results in a significant reduction in the size of the sanitizer libraries.<br>
<br>
Modified:<br>
    compiler-rt/trunk/cmake/config-ix.cmake<br>
<br>
Modified: compiler-rt/trunk/cmake/config-ix.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=254308&r1=254307&r2=254308&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=254308&r1=254307&r2=254308&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/cmake/config-ix.cmake (original)<br>
+++ compiler-rt/trunk/cmake/config-ix.cmake Mon Nov 30 11:42:30 2015<br>
@@ -30,6 +30,12 @@ check_cxx_compiler_flag(-fno-lto<br>
 check_cxx_compiler_flag(-msse3               COMPILER_RT_HAS_MSSE3_FLAG)<br>
 check_cxx_compiler_flag(-std=c99             COMPILER_RT_HAS_STD_C99_FLAG)<br>
<br>
+if(NOT WIN32 AND NOT CYGWIN)<br>
+  # MinGW warns if -fvisibility-inlines-hidden is used.<br>
+  check_cxx_compiler_flag("-fvisibility-inlines-hidden" COMPILER_RT_HAS_FVISIBILITY_INLINES_HIDDEN_FLAG)<br>
+  append_string_if(COMPILER_RT_HAS_FVISIBILITY_INLINES_HIDDEN_FLAG "-fvisibility-inlines-hidden" CMAKE_CXX_FLAGS)<br></blockquote><div><br></div><div>I think this should be next to</div><div><pre style="color:rgb(0,0,0)">append_list_if(COMPILER_RT_HAS_FVISIBILITY_HIDDEN_FLAG -fvisibility=hidden SANITIZER_COMMON_CFLAGS)</pre></div><div>in CMakeLists.txt.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
+endif()<br>
+<br>
 check_cxx_compiler_flag(/GR COMPILER_RT_HAS_GR_FLAG)<br>
 check_cxx_compiler_flag(/GS COMPILER_RT_HAS_GS_FLAG)<br>
 check_cxx_compiler_flag(/MT COMPILER_RT_HAS_MT_FLAG)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div></div>