<div dir="rtl"><div dir="ltr">+1</div><div dir="ltr"><span style="font-size:12.8px">std::bind(std::mem_fn(&</span><span style="font-size:12.8px">DAGCombiner::isAlias), this,</span><span style="font-size:12.8px"> std::placeholders::_1, StoreNodes[i].MemNode)</span></div><div dir="ltr">to me, this is less readable than the original code, due to the use of std::bind, std::mem_fn, <span style="font-size:12.8px">std::placeholders::_1, call nesting and the prefix notation.</span></div><div dir="ltr"><span style="font-size:12.8px"><br></span></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2015-11-29 13:28 GMT+02:00 Alex Bradbury via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 29 November 2015 at 04:37, Craig Topper via llvm-commits<br>
<div><div class="h5"><<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: ctopper<br>
> Date: Sat Nov 28 22:37:11 2015<br>
> New Revision: 254242<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254242&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254242&view=rev</a><br>
> Log:<br>
> [SelectionDAG] Use std::any_of instead of a manually coded loop. NFC<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br>
><br>
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=254242&r1=254241&r2=254242&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=254242&r1=254241&r2=254242&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)<br>
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Sat Nov 28 22:37:11 2015<br>
> @@ -11317,15 +11317,11 @@ bool DAGCombiner::MergeConsecutiveStores<br>
>          break;<br>
>      }<br>
><br>
> -    bool Alias = false;<br>
>      // Check if this store interferes with any of the loads that we found.<br>
> -    for (unsigned ld = 0, lde = AliasLoadNodes.size(); ld < lde; ++ld)<br>
> -      if (isAlias(AliasLoadNodes[ld], StoreNodes[i].MemNode)) {<br>
> -        Alias = true;<br>
> -        break;<br>
> -      }<br>
> -    // We found a load that alias with this store. Stop the sequence.<br>
> -    if (Alias)<br>
> +    // If we find a load that alias with this store. Stop the sequence.<br>
> +    if (std::any_of(AliasLoadNodes.begin(), AliasLoadNodes.end(),<br>
> +                    std::bind(std::mem_fn(&DAGCombiner::isAlias), this,<br>
> +                              std::placeholders::_1, StoreNodes[i].MemNode)))<br>
<br>
</div></div>I know this comes partly down to personal preference, but I can't help<br>
but think this would be more readable with a lambda (like the recent<br>
cleanups to CodeGenDAGPatterns by you and David Blaikie).<br>
<br>
Alex<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>