<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1" class="" style="word-wrap:break-word">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Would you be able to commit for me?<br>
<br>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">
<div style="font-family:Times New Roman; color:#000000; font-size:16px">
<hr tabindex="-1">
<div id="divRpF58277" style="direction:ltr"><font color="#000000" face="Tahoma" size="2"><b>From:</b> chris.matthews@apple.com [chris.matthews@apple.com]<br>
<b>Sent:</b> Thursday, November 19, 2015 8:42 PM<br>
<b>To:</b> Michael Daniels<br>
<b>Cc:</b> llvm-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [PATCH][LNT] Pass target to test-suites configure script<br>
</font><br>
</div>
<div></div>
<div>LGTM.
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Nov 19, 2015, at 7:31 AM, Michael Daniels via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="" style="font-size:10pt; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px; direction:ltr; font-family:Tahoma">
Hello,<br class="">
<br class="">
When lnt calls test-suite's configure script, it doesn't pass in a target option and will get configured for the host instead. If the host and target are not the same, then variables like TARGET_OS will not be what's expected, so you won't really be able to
compare against them.<br class="">
<br class="">
So if for example I ran lnt like this from a Linux host:<br class="">
<br class="">
lnt runtest nt --sandbox ./sandbox --cc i386-pc-solaris2.11-clang --test-suite ./test-suite --remote --remote-port=22 --remote-host=target_board --remote-user=user<br class="">
<br class="">
Then test-suite would end up with TARGET_OS=Linux in the Makefile's, instead of the expected SunOS.<br class="">
<br class="">
I have attached a potential patch that I have been using locally to work around this.<br class="">
<br class="">
Thanks,<br class="">
<br class="">
Mike<br class="">
</div>
<span class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px; float:none; display:inline!important">---------------------------------------------------------------------</span><br class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<span class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px; float:none; display:inline!important">This
transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone
other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by
unintended recipients is not authorized and may be unlawful.</span><br class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<span id="cid:783DD36A-C9BD-4B8A-AF9B-11447A4BD32F@apple.com"><lnt_target.diff></span><span class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px; float:none; display:inline!important">_______________________________________________</span><br class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<span class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px; float:none; display:inline!important">llvm-commits
mailing list</span><br class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<a href="mailto:llvm-commits@lists.llvm.org" class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px" target="_blank">llvm-commits@lists.llvm.org</a><br class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" class="" style="font-family:Helvetica; font-size:13px; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</div>
</div>
</body>
</html>