<html><head></head><body>Lgtm<br><br><div class="gmail_quote">On November 25, 2015 5:12:56 PM PST, Evgeniy Stepanov <eugenis@google.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">eugenis added inline comments.<br /><br />================<br />Comment at: lib/Transforms/Instrumentation/SafeStack.cpp:187<br />@@ +186,3 @@<br />+ if (AI->isArrayAllocation()) {<br />+ auto C = dyn_cast<ConstantInt>(AI->getArraySize());<br />+ if (!C)<br />----------------<br />eugenis wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Right. Returning 0 for unknown size allocas.<br /></blockquote>This would check such allocas for safety as if they are size 0, i.e. some operations are still allowed, but not any loads or stores.<br />We could actually do better by passing down the size as a Value and applying the SCEV magic to it. But (a) one thing at a time and (b) I doubt it actually matters.<br /><br /><br />Repository:<br /> rL LLVM<br /><br /><a href="http://reviews.llvm.org/D15002">http://reviews.llvm.org/D15002</a><br /><br /><br /><br /><br /></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>