<div dir="ltr">Hi Rong,<div><br></div><div>Typically, when there have been multiple active reviewers, it is common courtesy to wait for all of them to LGTM the patch. </div><div><br></div><div>I had further comments on the testing here (which the bots seem to have caught you on anyway), so I recommend reverting this patch for the moment and reopening the review.</div><div><br></div><div>-- Sean Silva</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 24, 2015 at 1:34 PM, Rong Xu <span dir="ltr"><<a href="mailto:xur@google.com" target="_blank">xur@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL254021: [PGO] MST based PGO instrumentation infrastructure (authored by xur).<br>
<br>
Changed prior to commit:<br>
  <a href="http://reviews.llvm.org/D12781?vs=41062&id=41079#toc" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12781?vs=41062&id=41079#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D12781" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12781</a><br>
<br>
Files:<br>
  llvm/trunk/include/llvm/IR/DiagnosticInfo.h<br>
  llvm/trunk/include/llvm/InitializePasses.h<br>
  llvm/trunk/include/llvm/LinkAllPasses.h<br>
  llvm/trunk/include/llvm/Transforms/Instrumentation.h<br>
  llvm/trunk/lib/IR/DiagnosticInfo.cpp<br>
  llvm/trunk/lib/Transforms/IPO/LLVMBuild.txt<br>
  llvm/trunk/lib/Transforms/Instrumentation/CFGMST.h<br>
  llvm/trunk/lib/Transforms/Instrumentation/CMakeLists.txt<br>
  llvm/trunk/lib/Transforms/Instrumentation/Instrumentation.cpp<br>
  llvm/trunk/lib/Transforms/Instrumentation/LLVMBuild.txt<br>
  llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/branch1.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/branch2.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/criticaledge.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/landingpad.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/loop1.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/loop2.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/loop3.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/single_bb.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/Inputs/switch.proftext<br>
  llvm/trunk/test/Transforms/PGOProfile/branch1_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/branch1_use.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/branch2_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/branch2_use.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/checksum_mismatch.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/criticaledge_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/criticaledge_use.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/landingpad_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/landingpad_use.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/loop1_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/loop1_use.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/loop2_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/loop2_use.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/loop3_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/loop3_use.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/noprofile_use.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/single_bb_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/switch_gen.ll<br>
  llvm/trunk/test/Transforms/PGOProfile/switch_use.ll<br>
<br>
</blockquote></div><br></div>